RDMA fixes, including memory deregistration - #191
Merged
Merged
Conversation
ritvikrao
marked this pull request as ready for review
July 28, 2026 15:25
Contributor
|
Create a sort-of benign dependency on pup, but it is ok I think. |
lvkale
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to fix issue #188.
Reconverse was inadvertently overrwriting CMK_SRC_DEST_ACK to CMK_SRC_ACK, causing an error with destination ACKing. This fixes that (allowing the pingpong results to show for nodegroups) but isn't complete yet, there needs to be code to clean up RDMA buffers. currently this error happens at the end:update: All RDMA tests now pass and pingpong runs correctly. This pr changes 2 things:
Using these changes requires the reconverse-rdma-fixes branch of Charm++; once this is merged into main, the reconverse-rdma-fixes branch will be merged into reconverse-specific-build in the charm repo