Skip to content

Fix begin at zero issue with constant data #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 522 commits into from
Closed

Fix begin at zero issue with constant data #1581

wants to merge 522 commits into from

Conversation

@etimberg
Copy link
Member

@etimberg etimberg commented Oct 28, 2015

Fixes #1579

We apply the ticks.beginAtZero option before seeing if we need to expand the scale range if scale.min === scale.max

etimberg and others added 30 commits July 5, 2015 14:36
@etimberg
Remove log call from polar area draw.
dfd48de
@etimberg
Legends for Line, Bar & Radar charts.
0caa2a7
@etimberg
Polar area legends
84aba3f
@etimberg
Doughnut legends (only makes sense for first dataset).
925e305
@etimberg
Built legend version
f3eb6f4
@etimberg
Merge branch 'v2.0-dev' of https://github.com/nnnick/Chart.js into v2…
f7dbb9d 
….0-dev
@tannerlinsley
Auto Skip Labels Attempt 1
d3ffc7a
@tannerlinsley
DatasetWidth now incorporates chartPaddingLeft
68b2256
@tannerlinsley
No Logs
452ef8b
@etimberg
Merge pull request #1354 from nnnick/v2.0-dev-feature-auto-skip-labels
f3303ce 
Auto-skip crowded axis-labels
@tannerlinsley
More Accurate animation frame dropper
26c210d
@tannerlinsley
chart.update(0) now draws instantly instead of not at all
f3706b0
@tannerlinsley
Build
31c5e45
@bakura10
Add support for mirror option
0c6f37f
@etimberg
Merge pull request #1357 from bakura10/mirror-linear-scale
3f24389 
Add support for mirror option on labels
@tannerlinsley
onAnimationComplete for zero-frame transitions
f5b44ac
@pratyushmittal
Added documentation for maxRotation of labels
ca0ece3
Update 00-Getting-Started.md
1cdc046 
tiny typo fix
@etimberg
Merge pull request #1365 from pratyushmittal/v2.0-dev
6f28711 
Added documentation for maxRotation of labels
@etimberg
Merge pull request #1367 from achichenin/patch-1
32f4f1e 
Update 00-Getting-Started.md
@etimberg
Fix the outerRadius calculation with respect to the border width. Pre…
9dfa9e8 
…viously the border width was divided by 2 twice rather than once.
@etimberg
Linear scale has proper padding in both vertical and horizontal orien…
87ac933 
…tations. Should prevent labels from getting cut off even when axes are not displayed.
@etimberg
During a mousemove event only re-render the chart instead of updating…
88896ab 
… it. Updating uses more memory & causes flicker in the axes.
@etimberg
initial logarithmic scale
eb83372
@fastrde
Fix for #1373
94c1ec4
@etimberg
Merge pull request #1374 from fastrde/v2.0-dev
7f345f0 
Fix for #1373
@etimberg
Fix bracket placement
dd62944
@etimberg
Proper template string caching
24a78e7
@etimberg
Merge branch 'v2.0-dev' of https://github.com/nnnick/Chart.js into fi…
3dd2ee7 
…x/template-caching
@etimberg
Merge pull request #1380 from etimberg/fix/template-caching
fce1c42 
Fixes template caching issues
tannerlinsley and others added 25 commits October 23, 2015 12:41
@tannerlinsley
Track lastTooltipActive for change animations
bc41909 
Since we split up the hover and tooltips modes, both changes need to be
tracked for visual updates between the two.
@tannerlinsley
Only use active datasets in the tooltip body
60f2426
@tannerlinsley
Merge pull request #1542 from nnnick/v2.0-dev-tooltip-refactor
3a20d11 
V2.0 dev tooltip refactor
@tannerlinsley
Bubble controller now skips on non-numerical coordinates
8081e9c
@tannerlinsley
Line controller now skips non-numerical coordinates
ae0d9b0
@tannerlinsley
Radar controller now skips non-numerical coordinates
afc40e7
@tannerlinsley
SplineCurve function now graciously handles skipped points
9d540ce
@tannerlinsley
Bad values for data are now converted to NaN
7b13e90
@tannerlinsley
Point Skipping now draws properly and is easier to understand
e50d2f7
@tannerlinsley
Scale min/max calculations now disregard bad values
ea57100
@etimberg
Improved number format function. Also improved the generation of smal…
0c3d9ec 
…l tick values
@etimberg
Fix tests affected by changes to default label formatter
f22c0f3
@tannerlinsley
recursive and accurate getRightValue
1c40d50
@tannerlinsley
radialLInear getPointPosition now rounds crazy decimals
2cd4b13 
This particular part of testing was succeeding in chrome, and failing
in firefox.  It should be rounded anyway.
@tannerlinsley
Line element and controller tests now coincide with the latest skipNu…
e7b71aa 
…ll refactor
@tannerlinsley
radialLinear scale tests now expect rounded values
6adf39e 
The rounding problems compounded in a few areas (like the
distanceFromCenter function and drawingArea property).  Those are now
more accurate.
@tannerlinsley
Use the new travis CI docker framework (hopefully)
4d009d1
@tannerlinsley
Merge pull request #1566 from nnnick/v2.0-dev-skip-null-fixes
6dc651a 
V2.0 dev skip null fixes
@tannerlinsley
Merge pull request #1567 from nnnick/fix/rounding
559ee62 
Better linear scale tick formatter + small tick generation
@tannerlinsley
Built Distributables
a4d11bd
@tannerlinsley
Updated Readme, and versions for beta release
e816534
@tannerlinsley
Rename 01-Scales to 01-Scales.md
dac859e 
Closes #1574
@tannerlinsley
Do not draw line up on first point of line
74c04a3
@tannerlinsley
element.line.js now passes tests
85572d7
@etimberg
Scale expansion if min === max will only occur after ticks.beginAtZer…
988034c 
…o is handled
@etimberg etimberg mentioned this pull request Oct 28, 2015
Closed
@stephanarts
Copy link

stephanarts commented Oct 28, 2015

There appears to still be an issue if all y values are '0'.

@etimberg etimberg closed this Oct 28, 2015
@etimberg etimberg mentioned this pull request Oct 28, 2015
Merged
@bart-blommaerts bart-blommaerts mentioned this pull request May 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.