allow to not insert iframe before canvas #3333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@simonbrunel has been working on a lot of resizing stuff lately. The plan was to make this happen if |
Member
|
Thanks @AlexKovalevych, I already changed that part of code (PR is coming). I don't think a new option is needed (as Evert said, the iframe will be injected only if responsive is true). Also, the |
Author
|
@simonbrunel great, when can i expect a new release with your fixes? |
Member
|
I guess for version 2.3.1 since 2.3.0 is about to be released. |
This was referenced Sep 23, 2016
Member
|
Implemented in #3364, closing. Thanks @AlexKovalevych! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to not insert iframe before canvas - to be able to work with shadow DOM