Confine gate procfs access#143
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfed34c7cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "run_cargo /bin/bash --norc -p -c 'gate_process_root=/proc/1;", | ||
| "for descriptor in \"$$gate_process_root\"/fd/*;", | ||
| "for hidden_proc_path in /proc/cpuinfo /proc/meminfo /proc/self/status /proc/version;", | ||
| "\"$$(/usr/bin/readlink -- \"$$gate_process_root/ns/ipc\")\" != \"$$6\"", | ||
| "\"$$(/usr/bin/sed -n \"2p\" \"$$gate_process_root/net/route\")\"", |
There was a problem hiding this comment.
The new contract replaces the previous full run_cargo isolation command with a few substrings, but none of these fragments require the runtime assertions for empty capability sets, NoNewPrivs, restored uid/gid/hostname, or stdio fd modes. _validate_makefile_entrypoint only counts these fragments, so a Makefile that deletes those hardening assertions while leaving these five substrings still reports no make.compiler_environment_contract finding, letting policy validation pass after the checks this contract is meant to freeze are removed.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation