Support UTF-8 and ISO-8859-1 source files - #22
Merged
chaseruskin merged 1 commit intoJul 26, 2026
Conversation
floze-the-genius
force-pushed
the
fix/issue-15-source-encoding
branch
from
July 19, 2026 10:22
3dd44c6 to
83c7114
Compare
floze-the-genius
marked this pull request as ready for review
July 19, 2026 10:22
Contributor
Author
|
CI reached the dependency audit after the build and failed on newly published |
Owner
|
Updated transitive dependencies on |
floze-the-genius
force-pushed
the
fix/issue-15-source-encoding
branch
from
July 26, 2026 19:19
83c7114 to
d9f91cf
Compare
Contributor
Author
|
Rebased onto current |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orbit readthrough the shared source decoder so non-ASCII Latin-1 characters are printed instead of replacedFixes #15.
Validation
cargo fmt --all -- --checkRUSTFLAGS="--deny warnings" cargo test(153 passed, 4 ignored)B2andE4:orbit read latin1emitted UTF-8C2 B2(²) andC3 A4(ä) with no replacement characters