Getting rid of vc- and vg- differences #7198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we trusted Bob to send the correct vc- or vg- prefix.
iequidoo
approved these changes
Sep 16, 2025
src/securejoin.rs
Outdated
| progress <= 1000, | ||
| "inviter_progress: contact {contact_id}, progress={progress}, but value in range 0..1000 expected with: 0=error, 1..999=progress, 1000=success." | ||
| progress == 0 || progress == 1000, | ||
| "inviter_progress: contact {contact_id}, progress={progress}, but value is not 0 (error) or 10000 (success)." |
Collaborator
There was a problem hiding this comment.
Suggested change
| "inviter_progress: contact {contact_id}, progress={progress}, but value is not 0 (error) or 10000 (success)." | |
| "inviter_progress: contact {contact_id}, progress={progress}, but value is not 0 (error) or 1000 (success)." |
UIs don't display a dialog with a progress bar anyway.
Inviter progress is for group if we added Bob to the group, not if Bob sent us vg-request-with-auth.
link2xt
force-pushed
the
link2xt/rxxsqrxttvkn
branch
from
169a89b to
1662b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.