Add chat_id to SecurejoinInviterProgress #7221
Conversation
link2xt
force-pushed
the
link2xt/usmzlnkpttzn
branch
from
54ecd25 to
cdd3b9b
Compare
link2xt
changed the title
link2xt
force-pushed
the
link2xt/usmzlnkpttzn
branch
from
cdd3b9b to
b267d46
Compare
missytake
left a comment
missytake
left a comment
There was a problem hiding this comment.
Can't judge all the rust, but great!
Why is SECUREJOIN_INVITER_PROGRESS always 1000 nowadays? I saw events earlier that still had 600,800, etc.
These events were not used anyway, only very old versions of Delta Chat showed a progress bar on the inviter side. Other events were removed in #7198 as for earlier events we cannot say for sure which group/chat the event belongs to. |
link2xt
force-pushed
the
link2xt/usmzlnkpttzn
branch
from
b267d46 to
5d66215
Compare
link2xt
force-pushed
the
link2xt/usmzlnkpttzn
branch
from
5d66215 to
bd3ec5a
Compare
| // which only have a single device | ||
| // and tests which don't care about the chat ID, | ||
| // so we pass invalid chat ID here. | ||
| let chat_id = ChatId::new(0); |
There was a problem hiding this comment.
This is a bit hacky, but I did not want to change the tests that depend on having this event on a second device. Actual users of this event should not be affected.
There was a problem hiding this comment.
It's better to add another event for ChatGroupMemberAdded messages in the future, which should be emitted from receive_imf where we know the chat id as well. For SecurejoinInviterProgress, zero chat id is fine i think
| // which only have a single device | ||
| // and tests which don't care about the chat ID, | ||
| // so we pass invalid chat ID here. | ||
| let chat_id = ChatId::new(0); |
There was a problem hiding this comment.
It's better to add another event for ChatGroupMemberAdded messages in the future, which should be emitted from receive_imf where we know the chat id as well. For SecurejoinInviterProgress, zero chat id is fine i think
|
Issue for adding |
|
Is anything necessary to pass this to the python RPC bindings? I still get events like these without |
|
Nevermind, it just seems that the steps in https://github.com/chatmail/core/tree/main/deltachat-rpc-client are incomplete to update deltachat-rpc-server after rust code changed. I had to manually copy the deltachat-rpc-server rust binary to my virtual environment. It works now :) |
|
Core 2.16 is not tagged yet. |
This is mostly for the bots: deltachat-bot/group-editor-bot#9