Migrate all crates to Rust edition 2024 - #33
Merged
Merged
Conversation
Bumps buildutil, init, loader, mkimage, and shared to edition 2024 (kernel and root Cargo.toml were already on it). Fixes the two resulting breakages: unsafe extern blocks and unsafe attributes.
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filed by an AI coding agent (Claude Code).
Summary
buildutil,init,loader,mkimage, andsharedto edition 2024 (kernel/rootCargo.tomlwere already on it).src/mm.rs:extern "C" { ... }block →unsafe extern "C" { ... }src/kmain.rsandinit/src/main.rs:#[export_name = "_start"]→#[unsafe(export_name = "_start")]Test plan
cargo kcheck/cargo icheck/cargo lcheck/cargo scheckall passcargo stest— all 54 tests + doctest passbuildutil/mkimage(host crates) compile clean./make-image.shbuild + headless QEMU boot reacheskernel_main, runs threads/allocator, and exits cleanly — matches expected debugcon sequence