fix(skills): use brand mark in recovery cards - #116
Merged
Conversation
Replace the remaining generic Sparkles icons in skills-catalog errors. Remove the unused Lucide barrel exports while preserving onboarding artwork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sparklesicons in skills-catalog recovery cards withCheatcodeMarkSparklesexports from the web icon barrelsSparkleartwork and vendored Office schema valueContext
Follow-up to #115 from a direct codebase audit; no Linear issue or plan document was created for this focused cleanup.
Decisions Made
CheatcodeMarkthrough the existingRecoveryCardcomponent slotSparklesentirelyHow to Review
integration-skills-grid.tsxfor both recovery-state callers.icons.tsandindex.tsonly remove the unused Lucide export.Verification
Sparklesorlucide-sparklesreferencespnpm lintpnpm typecheckpnpm turbo build --forcepnpm deadcodepnpm architecture:checkpnpm turbo skills:build/skillsvisual state was not entered because the browser's autofilled development account is not registered in this Clerk instance; no auth data was created or changed