Skip to content

fix(skills): use brand mark in recovery cards - #116

Merged
iamjr15 merged 1 commit into
mainfrom
fix/skills-recovery-brand-mark
Aug 2, 2026
Merged

fix(skills): use brand mark in recovery cards#116
iamjr15 merged 1 commit into
mainfrom
fix/skills-recovery-brand-mark

Conversation

@iamjr15

@iamjr15 iamjr15 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the two remaining generic Lucide Sparkles icons in skills-catalog recovery cards with CheatcodeMark
  • remove the now-unused Sparkles exports from the web icon barrels
  • preserve the custom orange onboarding Sparkle artwork and vendored Office schema value

Context

Follow-up to #115 from a direct codebase audit; no Linear issue or plan document was created for this focused cleanup.

Decisions Made

Decision Choice Alternatives considered Reasoning
Skills recovery visual Reuse CheatcodeMark through the existing RecoveryCard component slot Keep the generic icon or add a brand-specific mode Matches onboarding recovery states without duplicating surfaces or adding boolean API modes
Remaining sparkle artwork Preserve the custom onboarding SVGs Replace every star-shaped visual Those SVGs are intentional Paper design-system artwork, not generic Lucide placeholders
Icon barrel Remove Sparkles entirely Leave an unused export Prevents accidental reuse and is verified by the dead-code and repository search checks

How to Review

  1. Review integration-skills-grid.tsx for both recovery-state callers.
  2. Confirm icons.ts and index.ts only remove the unused Lucide export.

Verification

  • repository search finds no Sparkles or lucide-sparkles references
  • pnpm lint
  • pnpm typecheck
  • pnpm turbo build --force
  • pnpm deadcode
  • pnpm architecture:check
  • pnpm turbo skills:build
  • local Next.js process started and the Clerk sign-in route returned HTTP 200
  • protected /skills visual state was not entered because the browser's autofilled development account is not registered in this Clerk instance; no auth data was created or changed

Replace the remaining generic Sparkles icons in skills-catalog errors.

Remove the unused Lucide barrel exports while preserving onboarding artwork.
@iamjr15
iamjr15 merged commit b947a51 into main Aug 2, 2026
4 checks passed
@iamjr15
iamjr15 deleted the fix/skills-recovery-brand-mark branch August 2, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant