fix(agent): prevent fourth-tool workflow failure - #181
Merged
Conversation
Trim rotated skill capabilities before enforcing the stored bound. Route generic app requests through the managed builder and emit safe, run-scoped workflow failure classifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Every checkpointed tool step minted four independently scoped runtime capabilities. The fourth step combined twelve retained capabilities with four new ones, validated the sixteen-entry intermediate array against a twelve-entry schema, and failed before the requested shell command ran. Workflow retries repeated the same deterministic validation failure.
Architecture
Capability inputs are validated independently, then the retained-plus-new set is trimmed to the durable storage bound before final validation and persistence. App-builder inference remains a narrow projectless fallback: explicit mobile signals win, explicit web signals follow, and a generic app defaults to web unless a non-web runtime is named.
Workflow terminal and pre-tool infrastructure errors now emit only allowlisted categorical metadata. Prompts, commands, provider responses, stack traces, and credentials remain excluded.
Decisions made
apprequests to managed web app-builderEdge cases handled
dogfood-output/working directory is not included.Verification
pnpm lintpnpm typecheckpnpm turbo build --forcepnpm deadcodepnpm architecture:checkpnpm turbo skills:build