Remove dotenv dependency, use process.loadEnvFile()#32
Conversation
le-cong
left a comment
le-cong
left a comment
There was a problem hiding this comment.
just a few minor CI config comments
| steps: | ||
| - name: Checkout Code | ||
| uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
i just re-copied everything from package standards, should be good now.
| branchBuild: | ||
| name: Branch Build | ||
| runs-on: ubuntu-latest | ||
| name: Branch Build |
There was a problem hiding this comment.
move name before 'runs-on'?
| uses: actions/checkout@v4 | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| - uses: actions/checkout@v4 |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Check Imports | ||
| uses: checkdigit/github-actions/check-imports@main | ||
| - name: Install latest npm |
There was a problem hiding this comment.
should we keep Check Imports?
| "type": "module", | ||
| "engines": { | ||
| "node": ">=20.11" | ||
| "node": ">=20.12" |
There was a problem hiding this comment.
the luke document has to be updated to specify node>=20.12 to make this work, right?
There was a problem hiding this comment.
It probably should be updated at some point, but just updating to this package will be enough for npm to complain about the engine version, if you're running < 20.12.
|
Beta Published - Install Command: |
|
✅ PR review status - All reviews completed and approved! |
3 participants
Fixes #31