Skip to content

Release 7.14.1 - CardType and CardCategory enum fixes - #630

Merged
david-ruiz-cko merged 1 commit into
masterfrom
release/7.14.1
Jul 31, 2026
Merged

Release 7.14.1 - CardType and CardCategory enum fixes#630
david-ruiz-cko merged 1 commit into
masterfrom
release/7.14.1

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This release updates the CardCategory and CardType enums to better align with API responses and adds comprehensive test coverage for deserialization of all supported and unknown values. The changes improve consistency, future-proof the code against new values, and ensure robust handling of unexpected input.

Enum changes and alignment with API:

  • Updated CardCategory enum: Removed ALL, NOT_SET, and OTHER values, and replaced them with a single UNKNOWN value to match API responses. (src/main/java/com/checkout/common/CardCategory.java)
  • Updated CardType enum: Added NETWORK_TOKEN and UNKNOWN values, and adjusted alternate spellings for DEFERRED_DEBIT to include a space instead of an underscore. (src/main/java/com/checkout/common/CardType.java)

Test coverage improvements:

  • Added tests to ensure all supported CardType and CardCategory values (including alternate spellings and new values) are correctly deserialized from JSON. (src/test/java/com/checkout/metadata/CardMetadataSerializationTest.java)
  • Added tests to verify that unrecognized card_type and card_category strings are deserialized as null, ensuring resilience to future API changes. (src/test/java/com/checkout/metadata/CardMetadataSerializationTest.java)

Test infrastructure:

  • Added imports for LinkedHashMap and Map to support new test cases. (src/test/java/com/checkout/metadata/CardMetadataSerializationTest.java)

@david-ruiz-cko
david-ruiz-cko requested a review from a team July 30, 2026 13:09
@agent-wall-e

agent-wall-e Bot commented Jul 30, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Jul 30, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@david-ruiz-cko
david-ruiz-cko merged commit 0b4a75a into master Jul 31, 2026
6 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the release/7.14.1 branch July 31, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants