Merged
Conversation
Fixes #8482 by prompting to continue if the host key is not recognized. This attempts to tell Net:SSH to accept and write the key but it is only temporarily accepting. This changes the parameters of --ssh-verify-host-key (which is new) to take the Net::SSH values, which get passed through by train. This allows the user more options than only verifying or not. Signed-off-by: Bryan McLellan <btm@loftninjas.org>
lamont-granquist
approved these changes
May 13, 2019
tas50
reviewed
May 13, 2019
Contributor
|
@btm can you add the flag changes to the release notes |
Member
marcparadise
left a comment
marcparadise
left a comment
There was a problem hiding this comment.
Comments inline.
In addition, we'll want to make sure we test the logic in the new rescue to ensure that the right thing is done when the human chooses yes/no.
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
btm
force-pushed
the
btm/retry-fingerprint
branch
from
f620543 to
1bd3c85
Compare
marcparadise
approved these changes
May 13, 2019
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
btm
force-pushed
the
btm/retry-fingerprint
branch
from
904d9be to
0a1a78f
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8482 by prompting to continue if the host key is not recognized.
This attempts to tell Net:SSH to accept and write the key but it is only
temporarily accepting.
This changes the parameters of --ssh-verify-host-key (which is new) to
take the Net::SSH values, which get passed through by train. This allows
the user more options than only verifying or not.
Signed-off-by: Bryan McLellan btm@loftninjas.org