[OHAI-518] remove *.static.cloud-ips.com

[squaresurf]

Fixes issues with Pull Request #215

• fixes tests
• moves require "resolve" to top of file

[sersut]

Thanks for the patch @squaresurf & @gtmanfred. I'm 👍 on this.

In order to get this patch in we need @squaresurf to sign our CLA:

https://github.com/opscode/chef/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla

@opscode/client-eng anyone has some cycles to check this one out?

[squaresurf]

I signed the CLA via the new supermarket site. If that isn't live, then would you post a link where I should sign the CLA?

[btm]

Consider locking this to Resolv::ResolvError and whatever the exception is for the timout.

[btm]

Being a unit test, as we discussed, please add a stub so Resolv.getname doesn't actually go out and make a dns call. ensure that we have at least one test that explicitly checks that we get the ip address when DNS fails too.

[chef-supermarket]

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

• @gtmanfred

Please sign the CLA here.

[squaresurf]

@gtmanfred do you mind singing the CLA? That way you get credit and we can use your contributions to this?

[gtmanfred]

Rackspace already approved and added me to the company CLA signature whatever was required. So you should be all good to go.

[squaresurf]

Thank you @gtmanfred.

[btm]

Are these lines here default stubs? I would expect default stubs that ensure any new tests don't have to know to stub Resolv to be up in the top level before block starting at line 21. Individual tests can then override those stubs when they want different behavior.

[squaresurf]

I added that stub here because, I was under the impression that this was the location to set the default stub. Is line 21 actually the correct location for this stub? This is the first time I've edited an rspec file with shared_examples_for

[btm]

So my english was weird, but the concern is if this stub covers the it "should create rackspace" test which is up in the shared_examples, so we're thinking we need a stub for resolv at the top scoping level, up around line 21 of this file.

[chef-supermarket]

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

• @gtmanfred

Please sign the CLA here.

[squaresurf]

What needs to happen to get this merged?

[gtmanfred]

I am already on rackspace's cla, so i am not going to sign there.

[btm]

@cwebberOps could you look at helping get Rackspace's CCLA moved over to supermarket and their employees attached to it?

[btm]

so this is nearly good to go. @gtmanfred is on the old Approved Contributors list as 1814, which is fine.

we do need to make sure we stub out resolv for all of the tests, one way or another. so one of the stubs needs to get moved up to the top scope at the top of the unit test file. If someone can't work that out we'll do so and merge at some point.

[chef-supermarket]

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

• @gtmanfred

Please sign the CLA here.