Skip to content

fix: correct rendering of 1D traces over the 2D - #3870

Merged
hamed-musallam merged 4 commits into
mainfrom
traces-not-correctly-displayed
Dec 3, 2025
Merged

fix: correct rendering of 1D traces over the 2D#3870
hamed-musallam merged 4 commits into
mainfrom
traces-not-correctly-displayed

Conversation

@hamed-musallam

Copy link
Copy Markdown
Member

No description provided.

@hamed-musallam hamed-musallam linked an issue Dec 2, 2025 that may be closed by this pull request
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Dec 2, 2025

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: d12518a
Status: ✅  Deploy successful!
Preview URL: https://de23d2af.nmrium.pages.dev
Branch Preview URL: https://traces-not-correctly-display.nmrium.pages.dev

View logs

Comment thread src/component/2d/tools/XYLabelPointer.tsx Outdated
Comment thread src/component/2d/FooterBanner.tsx Outdated
Comment thread src/component/2d/useTracesSpectra.ts Outdated
@hamed-musallam
hamed-musallam force-pushed the traces-not-correctly-displayed branch from ce7fe00 to 63de3ab Compare December 2, 2025 11:43

@lpatiny lpatiny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks !

@hamed-musallam
hamed-musallam merged commit a6098c8 into main Dec 3, 2025
12 checks passed
@hamed-musallam
hamed-musallam deleted the traces-not-correctly-displayed branch December 3, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Traces not correctly displayed

3 participants