feat: add on-demand clearance refresh mode - #895
Merged
Conversation
Avoid scheduled browser solves for Console-only deployments while retaining automatic recovery after an upstream rejection invalidates the current clearance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_demandCloudflare Clearance modemanualandflaresolverrbehaviorProblem
Managed Clearance currently refreshes eligible egress nodes on a fixed schedule. Console scopes share the browser Clearance surface, so Console-only deployments can still invoke FlareSolverr even when no Grok Web accounts are enabled.
Each refresh starts a browser, visits
grok.comthrough the selected proxy, and attempts to solve the Cloudflare challenge. Failed solves can be retried shortly afterward. The resulting CPU usage is mostly attributed to FlareSolverr, Chromium, and proxy containers rather than the gateway that scheduled the work.Solution
The new
on_demandmode keeps the existing Clearance lifecycle but changes when the solver is invoked:RefreshDueClearancescalls do not solve a new ClearanceLease.InvalidateClearancepathExisting singleflight and distributed locking continue to deduplicate concurrent refresh attempts.
Existing modes remain unchanged:
manual: never invokes FlareSolverrflaresolverr: proactively refreshes stale Clearanceon_demand: invokes FlareSolverr only after explicit invalidationTest plan
go test ./internal/infra/config ./internal/infra/egressgo test ./internal/infra/provider/console ./internal/application/gateway ./internal/appon_demandmode