fix(idf): support legacy FatFS VFS registration API - #431
Merged
sakumisu merged 1 commit intoJul 31, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe FATFS registration code now includes ESP-IDF version information and selects the configuration-structure API for versions newer than 6.0. Older versions continue to use the legacy API. ChangesESP-IDF FATFS compatibility
Estimated code review effort: 1 (Trivial) | ~4 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ESP-IDF
release/v5.5is still widely used, so theesp_vfs_fat_register()call should remain compatible across different ESP-IDF versions.The new
esp_vfs_fat_register()API usingesp_vfs_fat_conf_tis only available in ESP-IDF 6.0.1 and later. ESP-IDF 6.0.0 and earlier, includingrelease/v5.5, still use the legacy four-argument API.This PR selects the appropriate API according to
ESP_IDF_VERSION, preserving compatibility with both mainstream ESP-IDF 5.5 releases and newer versions.Summary by CodeRabbit