refactor(core): share WASM cell-kind wire tags - #42
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun test packages/core/test/wire-tags.test.ts— 1 passbun test packages/core/test— 753 passbun run lint— pass (one existing corpus-size warning)bun run typecheck— passcd packages/wasm && cargo check --target wasm32-unknown-unknown— passbun scripts/check-import-cycles.ts— 88 modules acyclicbun run api:check— pass; baseline unchangedbun run changeset:ci— passKIND_*declarations only instore/wire-tags.ts; string decode sentinel uses sharedNO_STRING; both cache caps remain independentbun test— 1267 pass, 7 unrelated base failures: one stale docs compatibility inventory expectation and six benchmark-artifact checks whose recorded TypeScript 7.0.2 differs from the locked 6.0.3 compiler