fix(core): fail closed when paint workers fail - #44
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readyorfatal, including fatal context lossPublic API note
The worker readiness handshake requires adding
readyandfatalto the existing exportedWorkerAcknowledgementunion. That is an additive published API change, so keeping the API baseline byte-identical was impossible. This PR regenerates the public API baseline and generated worker docs.GridEvents["renderer-fallback"],grid.ts, and paint request payloads are unchanged.Evidence
Pre-fix reproduction:
bun test packages/core/test/worker-fallback.test.tsproduced 4 pass / 2 fail. Both new cases remained onrendererKind() === "worker"instead of falling back to"canvas"whengetContext("2d")returned null or no readiness message arrived.Post-fix:
bun test packages/core/test/worker-fallback.test.ts packages/core/test/worker-renderer.test.ts: 18 pass / 0 failbun test packages/core/test: 760 pass / 0 failbun run typecheck: passbun run api:check: pass after the required additive acknowledgement baseline/docs updatebun run lint: pass (existing oversized-corpus warning only)bun scripts/check-import-cycles.ts: 88 modules acyclicbun run changeset:ci: patch changeset acceptedbun test: 1274 pass / the same 7 known baseline failures