fix(core): repaint when device pixel ratio changes - #46
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A display-density change can leave the host at the same CSS size, so
ResizeObserverdoes not fire and the canvas keeps its old backing scale until another interaction.Change
matchMedialistener at the current DPR@portabilitytest also runs in WebKit in Required CI@sheetwrite/corepatch changesetVerification
bun test packages/core/test/device-pixel-ratio.test.ts— 2 passbun test packages/core/test— 762 passbun run typecheck— passbun run lint— pass (one existing oversized generated-data warning)GITHUB_BASE_REF=0.4.0 bun run changeset:ci— passThe broader local browser run passed 173 tests; the unrelated sustained-scroll timing check reported 40 ms against its 35 ms target on both attempts. The full root unit run retained the seven known baseline failures from issue #33 (one stale docs inventory assertion and six stale recorded benchmark toolchain assertions). Required CI is the merge gate.