fix: usage module cosmetic follow-ups - #67
Merged
Conversation
- internal/usage: add Traffic.IsSummary() helper so callers no longer encode the "summary row vs. day-zero" decision via the Day == 0 magic number; the TrafficList table renderer uses it too. - internal/usage: doc-note on Space that UsedWebspace is the sum of UsedHTDocsSpace, UsedChrootSpace, UsedDatabaseSpace, and UsedMailaccountSpace, so future readers do not double-count. - internal/cli: pre-validate "kasapi-cli usage traffic --year" ([2000, currentYear+1]) and "--month" (1..12) in PreRunE so obvious typos surface locally instead of after a KAS roundtrip. Closes #45.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/usage— add a(t Traffic) IsSummary() boolhelper so callers no longer rely on theDay == 0magic number; the table renderer is switched over and the decoder test asserts the helper for both the summary row and a per-day entry.internal/usage— doc-note onSpacethatUsedWebspaceis the sum ofUsedHTDocsSpace,UsedChrootSpace,UsedDatabaseSpace, andUsedMailaccountSpace, so future readers do not double-count.kasapi-cli usage traffic— pre-validate--year([2000, currentYear+1]) and--month(1..12) inPreRunE. Obvious typos now surface locally instead of after a KAS roundtrip.Closes #45.