(#1178) Initialize choco-playwright #1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3phhays
force-pushed
the
choco-playwright
branch
4 times, most recently
from
f08a6a3 to
5af66ab
Compare
st3phhays
force-pushed
the
choco-playwright
branch
2 times, most recently
from
f549a0a to
91776d3
Compare
This updates the tsconfig.json and files to reference imports of choco-astro with the new path. This was done to better create separation between choco-astro paths and the new choco-playwright paths.
The changes here utilize the new choco-astro package. A "baseline" test is added here that was previously housed in choco-theme. This tests performs basic actions to ensure Playwright is set up and running correclty. The tsconfig.json has been updated slightly to remove options that are not needed, as they are provided in the base tsconfig that it is extending from already.
st3phhays
force-pushed
the
choco-playwright
branch
from
91776d3 to
c6597b4
Compare
Member
Author
|
A new version of choco-theme and choco-playwright must be released before this can be merged. |
10 tasks
st3phhays
force-pushed
the
choco-playwright
branch
6 times, most recently
from
a0003a0 to
ca2ba1f
Compare
This upgrades choco-theme to 1.2.0 and also installs choco-playwright 0.1.0.
st3phhays
force-pushed
the
choco-playwright
branch
from
ca2ba1f to
a2503a1
Compare
Member
|
Thanks for getting this fixed up @st3phhays |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Introduces the new
choco-playwrightpackage for Playwright tests.Motivation and Context
We needed to centralize Playwright "things" so we could reuse across projects. This helps with maintainability.
Testing
yarn.yarn choco-theme.yarn playwright. Wait a short time. You should see tests start, they should all pass.Change Types Made
Change Checklist
Related Issue