Skip to content

knowledge: consolidate PRs #6–#13 (dedup + best-of-two reconcile) - #14

Merged
choiyounggi merged 2 commits into
mainfrom
knowledge/consolidate-6-13
Aug 3, 2026
Merged

knowledge: consolidate PRs #6–#13 (dedup + best-of-two reconcile)#14
choiyounggi merged 2 commits into
mainfrom
knowledge/consolidate-6-13

Conversation

@choiyounggi

Copy link
Copy Markdown
Owner

Consolidated review — knowledge PRs #6#13

Eight fork PRs (dch0202-rsquare, 2026-07-28 → 2026-08-02) were reviewed together
against AGENTS.md. Each PR was audited by an independent reviewer (format rules,
sources, vague-qualifier ban, ≤120 body lines, index/log invariants), then
cross-compared to catch duplication the per-PR flushes could not see — they branched
independently off the same main and rewrote the same shared index/log files. Fork
branches can't be edited from here and several PRs needed content changes (drop a
duplicate, merge a colliding page), so this branch carries the reconciled end-state
rather than merging each PR as-is (which would import the duplicates).

Verified best-practice

Sources are per-page and were live-verified in each originating PR's flush; the
independent re-reviews re-checked them. Landed pages and their evidence base:

Page Confidence Source basis
backend/common/llm/completion-response-validation verified OpenAI reasoning guide + chat object spec (5 finish_reason values), vLLM/LiteLLM reasoning fields; field incident (200/length/empty content/8,173-char reasoning)
backend/common/llm/context-window-budget verified Claude context-window docs, LiteLLM exception mapping, vLLM/Claude Code env-var docs
backend/common/integrations/externally-owned-defaults verified OpenAI deprecations (notice windows) + models list, LiteLLM model_discovery; field incident (alias removed between PR verify and review → 400)
backend/common/storage/object-key-persistence verified AWS S3 CompleteMultipartUpload + managed-upload API/source, aws-sdk-js issues #1158/#5656
infrastructure/containers/host-cgroup-visibility field-tested cgroup_namespaces(7), Docker --cgroupns=host, nsenter, k8s #103363; OrbStack repro
infrastructure/observability/missing-container-metrics verified/field-tested k8s resource-metrics-pipeline docs, kube-prometheus-stack values, kubernetes-mixin; OrbStack #2217 repro
platforms/environment/unicode-text-matching verified UAX #15, Unicode core §3.12, APFS FAQ, POSIX grep; local repro (macOS 15/APFS, grep 2.6.0-FreeBSD, Python 3.13)
platforms/shells/command-text-inspected-before-execution verified Claude Code hooks docs, POSIX shell §2.6; local reproduction
platforms/processes/non-interactive-cli-invocation verified GNU nohup, OpenBSD ssh/ssh_config, git, timeout man pages; no-request-in-gateway-log field incident
qa/document-verification/spec-document-gates field-tested ESLint, Google mutation testing, RFC 2119, Vale, markdownlint; 32/32 mutant / 62/62 intact RFC sessions
qa/document-verification/editing-a-gated-document field-tested pgrep, Vale, markdownlint; in-house editing methodology
testing/quality/checks-that-cannot-pass verified James Shore AoAD2, POSIX grep exit status, Semgrep rule-testing, pytest exit codes; BSD/ugrep measurement
testing/quality/spec-artifact-checks verified JSON Schema, ESLint RuleTester, pitest, GFM table spec; local cell-count repro + GitHub renderer cross-check
testing/quality/harness-reverse-controls verified mutation-testing + CI-control sources; field repro (re-fetched all cited URLs, PASS)

Three pages were reconciled from two overlapping PR versions each, keeping the more
complete/better-sourced body and folding in the other's unique cases:

Existing-layer check

Cross-PR and against-main duplication was the focus. Findings and resolutions:

Routing decision

Source PRs #6#13 are closed with a disposition comment crediting the author.

dch0202 and others added 2 commits August 3, 2026 16:40
Reviewed 8 fork knowledge PRs (#6#13) together against AGENTS.md and landed
14 pages, resolving cross-PR duplication the independent flushes could not see.

New categories: backend/common/llm, backend/common/integrations,
backend/common/storage, qa/document-verification.

Reconciled 3 pages from overlapping PR pairs (kept the more complete/better-
sourced body, folded in the other's unique cases):
- backend/common/llm/completion-response-validation (#6+#12)
- backend/common/integrations/externally-owned-defaults (#6+#12)
- platforms/processes/non-interactive-cli-invocation (#11+#12)

Dropped as duplicate/superseded:
- document-conformance-checks (#9, dup of #8 spec-artifact-checks)
- gateway-model-alias-defaults (#6, subsumed by externally-owned-defaults)
- llm-response-completeness (#12, folded into completion-response-validation)

Verified: all related:/inline ids resolve, every page indexed, no dup ids,
no page >120 body lines.

Co-authored-by: 최영기 <dch0202-rsquare@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant