Skip to content

knowledge: 9 insights — fresh-context review, gate parser/executor split, coordinator under tmux, sun_path limit, REPL sentinel await, allowlist bypass reproduction, version-drift gate, mock ts at emit (+3 folds onto #180/#181, 1 stale drop) - #183

Open
choiyounggi wants to merge 1 commit into
mainfrom
knowledge/choiyounggi-20260904-133717

Conversation

@choiyounggi

Copy link
Copy Markdown
Owner

Knowledge flush — 12 insight(s)

12 candidates claimed from ~/.dev-loop/queue (harvested 2026-08-19 … 2026-09-02). Outcome: 5 new pages, 4 amended main pages, 3 candidates folded onto open knowledge PRs (#180 ×2, #181 ×1), 1 dropped as stale. Every quote below was re-fetched with curl in this run after three read-only research agents drafted it; local reproductions were re-run in this session.

Verified best-practice

  1. Fresh-context review of LLM output (af294fb3f88881a1) — verified. https://arxiv.org/abs/2603.12123 (Song, "Cross-Context Review", Mar 2026) re-fetched: abstract reads "CCR reached an F1 of 28.6%, outperforming SR (24.6%, p=0.008, d=0.52), SR2 (21.7%, p<0.001, d=0.72), and SA (23.8%, p=0.004, d=0.57)"; SR2 vs SR p=0.11. Corroborated by this repo's own agents/test-quality-auditor.md ("so the session that wrote the code does not grade its own tests") and agents/integration-reviewer.md ("from a fresh context the coordinator's own session never reaches").
  2. Bypass-string construction + coordinator reproduction for allowlist code (5f91d867cf785a08) — verified for the technique (CWE-88 https://cwe.mitre.org/data/definitions/88.html; Cargo docs: --manifest-path package selection https://doc.rust-lang.org/cargo/commands/cargo-test.html, build scripts "It will then run the script" https://doc.rust-lang.org/cargo/reference/build-scripts.html, --config "should be in TOML syntax" https://doc.rust-lang.org/cargo/reference/config.html); the linkly-crew incident itself is field evidence (2026-08-31).
  3. Copied-plan premise must be read from the target manifest (412141e74acbc743) — field-tested (dev-loop mpa1 run, 2026-08-23); the mechanism is an internal-repo fact (dev-loop's marketplace entry is a url-source self-reference — confirmed by scripts/check-versions.sh's own comment).
  4. Parser vs executor separation in gate scripts (2548049fc5087ca2) — verified. CWE-78 https://cwe.mitre.org/data/definitions/78.html; timeout(1) https://man7.org/linux/man-pages/man1/timeout.1.html ("run a command with a time limit", exit 124 "if COMMAND times out"); local read of skills/loop-implement/scripts/gate-check.sh (--status … never executes CHECK, GATE_CHECK_TIMEOUT … via a perl alarm).
  5. Teardown build-cache bloat (fe6628a56fefc20b) — dropped. Candidate observed 2026-08-31; commit d37fd67 (2026-09-02, "fix(orchestrate): stop archive_scratch from archiving gitignored deps (orchestrate: safe-cleanup teardown hangs archiving gitignored deps (node_modules) via ls-files --others without --exclude-standard #170)") switched enumeration to git ls-files --others --exclude-standard and tests/safe-cleanup.bats:746 guards it. The proposed manual recursive delete of .worktrees/*/target before teardown would be stale advice against the current tool.
  6. Coordinator under tmux, not a client-bound relay PTY (c4ab8de2e9c06271) — field-tested. tmux(1) https://man7.org/linux/man-pages/man1/tmux.1.html ("Each session is persistent and will survive accidental disconnection", "all sessions are managed by a single server"); POSIX §11.1.10 https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/V1_chap11.html ("the SIGHUP signal shall be sent to the controlling process for which the terminal is the controlling terminal"); Orca docs https://www.onorca.dev/docs/ssh ("A short grace period (5 minutes by default, configurable per target)") — this corrects the candidate's --grace-time 0, which is not carried into the page as fact.
  7. False login expiry with idle sibling sessions (9a9038861c1d93fc) — field-tested, causal claim labelled hypothesis. https://code.claude.com/docs/en/authentication ("credentials are stored in ~/.claude/.credentials.json", a different CLAUDE_CONFIG_DIR "reads a different entry"); RFC 9700 §2.2.2 https://www.rfc-editor.org/rfc/rfc9700.txt ("Refresh tokens for public clients MUST be sender-constrained or use refresh token rotation") supports the general pattern only.
  8. Plugin version drift gate (5b73ca3b8aeee489) — verified. https://code.claude.com/docs/en/plugin-marketplaces ("Avoid setting version in both plugin.json and the marketplace entry. Claude Code always uses the plugin.json value without warning"); https://raw.githubusercontent.com/mattpocock/skills/main/scripts/sync-plugin-version.mjs (--checkprocess.exit(1), wired as check-plugin-version); this repo's scripts/check-versions.sh + .github/workflows/test.yml "Version gate (marketplace.json vs plugin.json)" step.
  9. Rust inline tests invisible to test-floor.sh (b9e2ed778fd6d661) — verified. Local read of skills/orchestrate/scripts/test-floor.sh classify() (patterns *.bats, test_*.py, *_test.go, *.test.*, */tests/* — no .rs); Rust Book https://doc.rust-lang.org/book/ch11-03-test-organization.html ("put unit tests in the src directory in each file with the code that they're testing … create a module named tests in each file").
  10. Unix socket sun_path limit in deep worktrees (886a2b6aff8e8a6b) — verified. macOS SDK sys/un.h line 79 char sun_path[104];; Linux https://man7.org/linux/man-pages/man7/unix.7.html char sun_path[108]; Node https://nodejs.org/api/net.html ("Typical values are 107 bytes on Linux and 103 bytes on macOS"); local reproduction this run: net.createServer().listen(<131-byte path under ~/.dev-loop/tmp>)listen EINVAL.
  11. Top-level await for sentinel-driven REPL payloads (285976623fb9d890) — verified. https://nodejs.org/api/repl.html ("Support for the await keyword is enabled at the top level"); local reproduction this run (Node v26.7.0, node -i via piped stdin): unawaited IIFE printed only Promise { <pending> }, awaited form printed done-awaited.
  12. Stamp mock event timestamps at emit, assert monotonicity (966887be5b42f5fc) — field-tested. Research agent read linkly-crew commit 530e7e2 ("stamp MockEventSource ts at delivery, not build time") and its regression test; no external doc names this specific pattern, so it rides on the host pages' verified methodology.

Existing-layer check

Pages read: qa-process-llm-review-pipelines, qa-process-evaluating-review-feedback, qa-process-adversarial-change-review, infrastructure-agent-orchestration-session-context-token-budget, security-input-validation-at-trust-boundaries, platforms-shells-option-like-argument-values, qa-exploratory-guard-true-path-coverage, qa-document-verification-spec-document-gates, infrastructure-config-keys-ahead-of-their-consumer, platforms-shells-command-text-inspected-before-execution, security-agent-exposure-in-session-tool-exposure, testing-quality-checks-that-cannot-pass, infrastructure-agent-orchestration-pane-delivery-confirmation, infrastructure-agent-orchestration-control-signals-vs-primary-artifacts, infrastructure-agent-orchestration-session-completion-gates, infrastructure-agent-orchestration-usage-limit-paused-workers, platforms-tools-version-keyed-artifact-cache, qa-document-verification-generated-reference-drift-gates, infrastructure-ci-cd-pipeline-structure, platforms-tools-plugin-mcp-server-registration, testing-quality-tests-that-cannot-fail, testing-quality-unasserted-return-fields, testing-mocking-what-to-mock, platforms-filesystems-paths-case-and-line-endings, infrastructure-agent-orchestration-worktree-isolated-workers, testing-async-async-testing, platforms-processes-driving-a-tui-in-a-tmux-pane, platforms-processes-non-interactive-cli-invocation, qa-environments-browser-console-capture-gaps, databases-transactions-application-clock-vs-database-timestamps

Also read on open-PR branches (not on main, so not listed above): infrastructure-agent-orchestration-login-expiry-during-unattended-turns and testing-quality-assertion-scanner-false-positive-on-unittest-convention (PR #180), infrastructure-agent-orchestration-checkable-claims-in-an-adopted-plan (PR #181).

Open-PR check

Open knowledge/* heads listed via gh pr list --search "head:knowledge/": #179 knowledge/choiyounggi-20260903-172728, #180 knowledge/choiyounggi-20260903-184706, #181 knowledge/choiyounggi-20260903-203836, #182 knowledge/choiyounggi-20260903-214027. Each head was fetched and diffed against origin/main -- wiki/.

Candidate Overlapping head Verdict
#7 false login expiry (9a9038861c1d93fc) #180 login-expiry-during-unattended-turns.md — same symptom, but that page treats expiry as always genuine fold — pushed to #180 as commit bc1cac7 (+1 edge row, +3 sources, index row extended), PR comment posted
#9 Rust inline tests vs test-floor (b9e2ed778fd6d661) #180 assertion-scanner-false-positive-on-unittest-convention.md — same root cause (path/name classifier with no entry for the convention) fold — same commit bc1cac7 (+When-this-applies paragraph, +Do item 6, +1 edge row, +3 sources, applies_to +rust, index row extended)
#3 copied-plan premise (412141e74acbc743) #181 checkable-claims-in-an-adopted-plan.md — same page family, case not yet present fold — pushed to #181 as commit 58c6bd1 (+Do item 7, +1 Finding row, +1 source, log line), PR comment posted
#2 allowlist bypass #181 touches validation-at-trust-boundaries (spatial-range case), #182 touches adversarial-change-review related: line only new (merge on main, body hunks do not collide)
#4 parser vs executor #179/#181 touch spec-document-gates (word-boundary fix, related:), #179/#180 touch checks-that-cannot-pass related: new page; skipped those back-links
#1, #6, #8, #10, #11, #12 none new
#5 teardown cache none drop (stale against d37fd67, see above)

No sibling duplicate PR was opened; this flush's PR carries only main-branch changes.

Routing decision

Candidate Target Why
#1 fresh-context review qa/process/fresh-context-code-review (new) Review-process decision; peer of llm-review-pipelines / evaluating-review-feedback with a distinct trigger
#2 allowlist bypass construction qa/process/adversarial-change-review (merge) Same trigger family — high-risk diff review at integration stage
#3 copied-plan premise infrastructure/agent-orchestration/checkable-claims-in-an-adopted-plan (fold, PR #181) Plan-adoption checks live there
#4 parser vs executor testing/quality/gate-parsing-vs-command-execution (new) spec-document-gates states check authoring belongs to testing/quality
#5 teardown cache dropped Fixed on main 2026-09-02 (#170)
#6 coordinator PTY infrastructure/agent-orchestration/client-bound-pty-coordinator-loss (new) Sibling of the tmux/orchestration lifecycle pages
#7 false login expiry infrastructure/agent-orchestration/login-expiry-during-unattended-turns (fold, PR #180) Same symptom page
#8 version drift gate platforms/tools/version-keyed-artifact-cache (merge) Only page on the plugin.json/marketplace.json pair; adds the CI-prevention half
#9 Rust inline tests testing/quality/assertion-scanner-false-positive-on-unittest-convention (fold, PR #180) Same scanner-gap root cause
#10 sun_path platforms/filesystems/unix-domain-socket-path-length (new) Path-length is a filesystem concern per the domain description
#11 REPL sentinel platforms/processes/sentinel-driven-repl-payloads (new) Driving an external process, matching the category's existing pages
#12 mock timestamps testing/quality/unasserted-return-fields + testing/mocking/what-to-mock (merge rows) Assertion side and mock-authoring side each have an exact host page

No new category was needed. Lint: wiki-structure-checks.js wiki → 280 pages, 0 findings; wiki-lint-prohibitions.js wiki → 0 violations (1 pre-existing info).

…parser/executor split, coordinator under tmux, sun_path limit, REPL sentinel await (+3 merges, 3 folds, 1 drop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-loop:knowledge Auto-opened wiki knowledge ingest PR (owner reviews & merges)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant