sync #26
Merged
sync #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the number of global functions by moving it to instance method `FuncInfo::findEquivalent()`.
This fixes a ZEND_RC_MOD_CHECK() assertion failure when building with "-DZEND_RC_DEBUG=1 --enable-debug --enable-zts". php_dl() is called after startup, and manipulates the refcount of persistent strings, which is not allowed at this point of the lifecycle. The dl() function disables the ZEND_RC_MOD_CHECK() assertion before calling php_dl(). This change applies the same workaround in FPM. Closes GH-18075
* PHP-8.3: Disable ZEND_RC_MOD_CHECK() while loading shared extension in FPM
* PHP-8.4: Disable ZEND_RC_MOD_CHECK() while loading shared extension in FPM
… types than node lists Closes GH-18073.
* PHP-8.4: Fix GH-18090: DOM: Svg attributes and tag names are being lowercased
This avoids repeated lookups in the function table for the same function name. Although this optimization is observable, i.e. defining a function via an include in between 2 JMP_FRAMELESS for the same function, this cannot be relied on already as far as I know if the optimizer runs.
* PHP-8.4: Fix IN_ARRAY optimization
* PHP-8.3: Fix xinclude destruction of live attributes
* PHP-8.4: Fix xinclude destruction of live attributes
…e request. (#18025) it is an internal table and oid is a real Oid (uint32_t) value.
* PHP-8.4: Update IR
Fixed in dstogov/ir#110 and merged via b932c26. Closes GH-18113.
* PHP-8.4: Add test for GH-18113
Preloading shutdown calls request shutdown which will deactivate the virtual cwd state. However, further startup code still assumes the state that was set by virtual_cwd_startup(). So we need to reactivate it manually. Creating a test was a bit difficult because the INI setting I wanted to test this with is overridden by the test runner apparently. To reproduce the issue, create an empty file test.php and execute this in a ZTS build: `php -d opcache.preload=./ext/opcache/tests/preload_class_alias_2.inc -d "error_log=" -d "allow_url_include=1" test.php` Closes GH-18117.
* PHP-8.3: Fix GH-18112: NULL access with preloading and INI option
Removing missleading comment
It either returns true or throws an Error
It was only used once, and removing it reduces the size of a userland FTP object by 4096 bytes
The size should be the second one
Future uses of this internal API are planned, and we can easily avoid an allocation by factoring out the common code.
Fix some types at the same time
Instead of an if/else
and a handful more error code paths. close GH-18250
This avoids another separate allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.