fix: fixes docs ci version bump#24
Merged
Merged
Conversation
fix: break out socket timeouts fix: reduce possible fd leak
Contributor
There was a problem hiding this comment.
Pull request overview
Adds separate accept vs recv timeout handling and improves server shutdown responsiveness by interrupting blocking accepts, along with corresponding test coverage, docs updates, and a patch version bump.
Changes:
- Introduces
accept_timeoutandrecv_timeoutalongsidetimeoutacrossJsonSocket/clients/servers andServerFactory. - Adds a wakeup socket mechanism in
ThreadedServer/ServerFactoryto break out of blocking accept loops on stop. - Expands unit/integration/BDD coverage and updates packaging metadata + README; bumps version to 2.0.1.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_unit_coverage.py | Adds unit tests covering accept/recv timeout routing and worker timeout behavior. |
| tests/test_integration_failures.py | Adds integration regression tests for client behavior across read timeouts and delayed responses. |
| tests/test_additional_coverage.py | Adds coverage for wakeup socket paths, accept/select handling, and worker/thread edge cases. |
| pyproject.toml | Updates license metadata fields and relocates license-files configuration. |
| jsocket/tserver.py | Adds wakeup socketpair + select()-based accept waiting; refines ServerFactoryThread/ServerFactory timeout plumbing. |
| jsocket/jsocket_base.py | Adds separate accept/recv timeouts and updates timeout application behavior in client/server flows. |
| jsocket/_version.py | Bumps package version to 2.0.1. |
| features/timeout_behavior.feature | Adds BDD scenarios for stopping with long accept timeout and separate accept vs recv timeouts. |
| features/steps/steps.py | Adds behave steps for new timeout scenarios and waiting; adjusts server default timeout behavior. |
| README.md | Documents new timeout semantics and clarifies examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chris-piekarski
force-pushed
the
fixes_docs_ci_version_bump
branch
from
7a63e08 to
9d2fd68
Compare
Contributor
|
@chris-piekarski I've opened a new pull request, #25, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * fix: separate connect and recv timeouts in JsonClient Co-authored-by: chris-piekarski <411331+chris-piekarski@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chris-piekarski <411331+chris-piekarski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.