fix: separate connect and recv timeouts in JsonClient#25
Merged
Conversation
Co-authored-by: chris-piekarski <411331+chris-piekarski@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on CI version bump documentation
fix: separate connect and recv timeouts in JsonClient
Feb 7, 2026
chris-piekarski
approved these changes
Feb 7, 2026
chris-piekarski
added a commit
that referenced
this pull request
Feb 7, 2026
* fix: address possible desync framing scenarios * ci: fix makefile and lint issues * ci: actions lint error * ci: additional unit and behave coverage fix: break out socket timeouts fix: reduce possible fd leak * docs: update for dual timeout options * ci: legacy... * fix: separate connect and recv timeouts in JsonClient (#25) * Initial plan * fix: separate connect and recv timeouts in JsonClient Co-authored-by: chris-piekarski <411331+chris-piekarski@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chris-piekarski <411331+chris-piekarski@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: chris-piekarski <411331+chris-piekarski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recv_timeoutis documented as controlling "connection read timeout" but was also governingconnect()operations, making it impossible to tune connect and read timeouts independently.Changes
JsonClient.__init__: Usetimeoutfor initial socket (governs connect attempts)JsonClient.connect(): Switch torecv_timeoutafter successful connectiontimeoutfor subsequent connect attemptsExample
Previously both operations would use 30.0s timeout.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.