Skip to content

Auto-review follow-ups for PR #226: refactor(extension-core): split background.ts into purpose-shaped modulesΒ #227

Description

@github-actions

Tracking auto-review follow-ups for #226 (verdict: warn).

🟑 Nits

  • Seven symbols exported but referenced only within their own module β€” drop export on hello.ts:sameDomainSet, DEFAULT_CAPABILITIES, effectiveCapabilities, DeclaredScope, declaredScope, badge.ts:syncBadge, pending-records.ts:PendingRecordBase (all file-private on origin/main; PR description lists six and misses declaredScope)
  • tests/session-scope-teardown.test.ts comment claims a thirteenth scope map omitted from clearAllSessionScopes "must fail here", but both assertions read the hand-maintained ALL_SCOPE_MAPS literal β€” derive the list from the module's exports (Object.entries(sessionScope).filter(e => e[1] instanceof Map)) to make the claim true

When addressing the review on #226, resolve each item and add Closes #<this issue> to the PR once everything is genuinely fixed; deferred items stay open here. See the auto-review follow-up convention in CLAUDE.md.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions