docs(bootstrap): point the module header at createSessionLifter - #193
Conversation
Auto-review follow-up for #191. The file-level comment still described the module as one-shot-only and never mentioned createSessionLifter, which is now the recommended entry point — leaving the first thing a reader sees pointing at the shape the PR set out to stop being the default. Closes #192 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Claude finished @chrischall's task in 44s —— View job Review: docs(bootstrap): point the module header at createSessionLifter
FindingsThis documentation-only PR updates the module header comment in What changed:
Quality assessment: ✅ Correctness: The documentation accurately describes the API design. The module now explicitly teaches the right pattern first—renewable lifts for session managers—with the one-shot ✅ Adherence to conventions: Follows the project's guidance from CLAUDE.md: "Only add one [comment] when the WHY is non-obvious" — this header now explains both what the functions do and why the choice matters (the expiry dead-end failure mode). ✅ Completeness: The ✅ No breaking changes: Docs only; 1092 tests pass, typecheck clean. No code paths modified. Verdict: pass |
|
✅ Auto-review verdict: pass — Documentation-only PR that correctly reframes the bootstrap module header to lead with |
🤖 I have created a release *beep* *boop* --- ## [1.9.1](v1.9.0...v1.9.1) (2026-08-03) ### Documentation * **bootstrap:** point the module header at createSessionLifter ([#193](#193)) ([81334fa](81334fa)), closes [#192](#192) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Auto-review follow-up for #191.
The file-level comment still described the module as one-shot-only and never mentioned
createSessionLifter— so the first thing a reader sees pointed at exactly the shape that PR set out to stop being the default.Rewritten to lead with the choice:
createSessionLifterfor anything whose session can expire,bootstrapfor genuinely one-shot callers (the user-invokedcapture_sessiontool pattern). Includes the why, since the failure mode is what makes the default matter — capturing a value once is how an MCP ends up working for one credential lifetime and then dying with no way back.Docs only; 1092 tests pass, typecheck clean.
Closes #192