refactor(server): drop the concatBytes imports the signature change orphaned - #224
Conversation
…rphaned #223. Six integration fixtures and `peer.ts` still imported `concatBytes` after their signature payloads moved to `readySignaturePayload()`. Dead either way, and in `peer.ts` actively misleading: the import was the last trace of a payload shape that is now a security bug. `host.ts` keeps its import — it still concatenates for the PEER hello signature, which is a different payload and unaffected. Closes #223 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Claude finished @chrischall's task in 56s —— View job Review: Remove unused
|
|
✅ Auto-review verdict: pass — All seven |
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.11.0...v2.0.0) (2026-08-06) ### ⚠ BREAKING CHANGES * **protocol:** bind the ephemeral key into the ready signature ([#222](#222)) ### Features * **protocol:** add write_cookies, the one verb that can repair a rotated session ([#211](#211)) ([b2557c2](b2557c2)) * **protocol:** bind the ephemeral key into the ready signature ([#222](#222)) ([c13aeed](c13aeed)) * **server:** let a request name the tab that relays it ([#207](#207)) ([c5d3f4d](c5d3f4d)) * **server:** pin the extension's identity, and verify it on the peer path ([#213](#213)) ([0eeced7](0eeced7)) ### Bug Fixes * **cli:** let a real filesystem error be itself, not "no extension pin" ([#221](#221)) ([c87a864](c87a864)), closes [#220](#220) * **cli:** validate --via-tab before connecting, like the request URL ([#210](#210)) ([959fcc5](959fcc5)) * **extension:** reattach the write_cookies doc block, and name the writable cookies as writable ([#215](#215)) ([2730c4a](2730c4a)) * **extension:** use the guarded caps local for the cookie heading ([#217](#217)) ([f95c832](f95c832)) * **server:** release only our own extension claim, and stop guessing scoped names ([#219](#219)) ([3d90a64](3d90a64)), closes [#218](#218) * **server:** type no-tab rejections so they stop reading as version mismatches ([#205](#205)) ([dc30bd9](dc30bd9)) ### Refactor * **server:** drop the concatBytes imports the signature change orphaned ([#224](#224)) ([4985ba7](4985ba7)), closes [#223](#223) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The one nit from #223, on a fresh branch — #222 merged while I was fixing it.
Six integration fixtures (
mutual-auth-idb,graphql-query,read-cookies,all-bootstrap-verbs,two-mcps,reconnect) andpeer.tsstill importedconcatBytesafter their signature payloads moved toreadySignaturePayload(). Checked each rather than trusting the list: all seven had zero remaining call sites.host.tskeeps its import — it still concatenates for the peer hello signature (mcpId || sessionNonce), which is a different payload and unaffected by #222.Worth removing beyond tidiness in one case: in
peer.tsthe import was the last trace of the payload shape that #222 established is a security bug, sitting a few lines from the code that no longer builds it.1233 tests, typecheck clean across all six workspaces.
Closes #223