fix(ci): restore the larql-vindex coverage gate - #368
Merged
Conversation
…bt, baseline the structurally unreachable The gate has been red on `main` since #363, which means it can no longer tell anyone about a real regression: the next genuine coverage drop is indistinguishable from the standing failure. Seven entries, added for TWO different reasons that must not be conflated. **DEBT — issue #367.** The five gguf/* files landed with ~2100 lines carrying four inline tests between them (emit/, preflight/ and walk/ have none): gguf/export.rs 50.8% 419 lines, 1 test gguf/emit/mod.rs 83.0% 517 lines, 0 gguf/vocab.rs 83.4% 400 lines, 3 gguf/walk/mod.rs 88.5% 434 lines, 0 gguf/preflight/mod.rs 88.8% 346 lines, 0 They are baselined AT TODAY'S LEVELS. That is a ratchet, not an exemption: the gate is green now and any drop below today still fails, so regression detection is restored while the debt stays visible and owned. Raise them as tests land; do not lower them. export.rs at 50.8% is the priority — half the export path is unexercised. **STRUCTURAL — do not chase with more tests.** represent/kda_candidate_real.rs (4.4%) is a #[cfg(test)] driver gated on a real 48B container the ubuntu job does not have, and kda_candidate.rs (75.2%) carries gpu-gated paths the non-gpu coverage run cannot reach. Same class as the integer.rs/stationary.rs/physical.rs entries the policy note already documents. Verified with CI's own script against a measured report: `Coverage policy passed: total 93.42% lines, 365 files checked, 304 files at 90.0% default, 61 debt baselines.`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
larql-vindexcoverage gate has been red onmainsince #363. A permanentlyred gate is worse than no gate: the next genuine coverage regression becomes
indistinguishable from the standing failure.
Seven entries, added for two different reasons that must not be conflated.
Debt — tracked in #367
Five
gguf/*files landed with ~2,100 lines carrying four inline tests betweenthem (
emit/,preflight/andwalk/have none):gguf/export.rsgguf/emit/mod.rsgguf/vocab.rsgguf/walk/mod.rsgguf/preflight/mod.rsBaselined at today's levels — a ratchet, not an exemption. The gate is green
now and any drop below today still fails, so regression detection is restored
while the debt stays visible and owned. Raise them as tests land; do not lower
them.
Structural — do not chase with more tests
represent/kda_candidate_real.rs(4.4 %) is a#[cfg(test)]driver gated on areal 48 B container the ubuntu job does not have;
kda_candidate.rs(75.2 %)carries gpu-gated paths the non-gpu coverage run cannot reach. Same class as the
integer.rs/stationary.rs/physical.rsentries the policy note alreadydocuments, and the note now says so explicitly.
Verification
CI's own
scripts/check_coverage_policy.py, against a measured report:Known unrelated reds
cargo-auditandcargo-deny · advisories(RUSTSEC-2026-0269) are red onmainindependently of this change. The
benchgate is separately unreliable — itflagged a +31 % "regression" in
larql-computeon a branch that did not touchthat crate; that is shared-runner variance against a
mainbaseline and is thenext instrument fix, not addressed here.