fix(compute): ungate kernel test imports on x86 - #385
Merged
Conversation
…n x86 The Q8K refusal tests added in #384 use BLOCK_BYTES and Q6K_BLOCK_BYTES on every architecture, but tests.rs imported both under the aarch64+neon cfg, and the AVX2 parity test still discarded the kernel's new Result inside its unsafe block. Neither compiles on x86_64, so the larql-compute test job goes red on ubuntu and windows while the aarch64 gates stay green. Import the two constants unconditionally and `.expect` the AVX2 call. Verified with `cargo clippy --target x86_64-apple-darwin --all-targets` and an x86_64 `--no-run` test build alongside the aarch64 gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(compute): ungate the kernel test imports the refusal tests need on x86
The Q8K refusal tests added in #384 use BLOCK_BYTES and Q6K_BLOCK_BYTES on
every architecture, but tests.rs imported both under the aarch64+neon cfg,
and the AVX2 parity test still discarded the kernel's new Result inside its
unsafe block. Neither compiles on x86_64, so the larql-compute test job goes
red on ubuntu and windows while the aarch64 gates stay green.
Import the two constants unconditionally and
.expectthe AVX2 call.Verified with
cargo clippy --target x86_64-apple-darwin --all-targetsandan x86_64
--no-runtest build alongside the aarch64 gates.