fix(settings): wire up version dialog button in ServerHealthStatus - #253
Merged
Conversation
…vent nesting issues
…nt Radix nesting issue
…log render Remove the createPortal + useRef guarded-close pattern for the version dialog (introduced to work around Radix nesting issues). Instead render VersionSelectDialog directly inside the Dialog and prevent outside interactions via onInteractOutside/onFocusOutside/onPointerDownOutside preventDefault. Delete the obsolete VersionSelectContent component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Versions" button in the ServerHealthStatus component (visible inside the Settings dialog) was not wired up — the
onOpenVersionDialogprop was never passed fromSettingsDialog, so clicking the button did nothing.The actual
VersionSelectDialogcomponent existed insideOpenCodeConfigManagerbut its opener button was hidden because the component is rendered withhideHealthStatus={true}inSettingsDialog.Fix: Lift
isVersionDialogOpenstate up toSettingsDialog, passonOpenVersionDialogtoServerHealthStatus, and renderVersionSelectDialogdirectly inSettingsDialog. This makes the visible "Versions" button functional again.Files