fix(frontend): stabilize ScheduleJobDialog render loop and improve accessibility#315
Merged
Merged
Conversation
…cessibility Resolve a "Maximum update depth exceeded" render loop in ScheduleJobDialog while prompt templates are loading, and add accessibility labels across the frontend. Also unregister the service worker in dev to avoid stale caches. - ScheduleJobDialog: use a stable EMPTY_TEMPLATES constant and split template matching into its own effect keyed on [templates, job, open] instead of running inside the init effect that depends on templates - Add ScheduleJobDialog.loading.test.tsx regression test for the loading state - serviceWorker: unregister existing registrations and clear caches in DEV so stale workers do not serve outdated assets locally - App: replace shell div with semantic <main> - SettingsDialog: add sr-only DialogTitle for screen readers - Add aria-labels to icon-only buttons in back-button, combobox, header, GlobalSchedules, and Repos - index.html: add mobile-web-app-capable meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve a "Maximum update depth exceeded" render loop in ScheduleJobDialog while prompt templates are loading, and add accessibility labels across the frontend. Also unregister the service worker in dev to avoid stale caches.