Say what the package does now, not what it did - #25
Merged
Conversation
Title, Description, and the README's opening line all described a package that fetches Copernicus data and matches it to species observations. matchData()'s arguments were renamed this afternoon precisely because that is not what it does: the join is a general spatiotemporal nearest-feature match, and either side may be stations, tag positions, or another gridded product. That made these stale in the way that matters. Not incomplete - wrong. A reader deciding whether the package fits their problem would have concluded it did not, on the strength of a sentence describing an earlier version of it. Also brings the Description up to date on what has been added since it was last written: daily fetches by period or by named date, parallel downloads, and caching. The GitHub description and topics are updated to match, with netcdf, time-series, and data-pipeline added. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title,Description, and the README's opening line all described a package that fetches Copernicus data and matches it to species observations.matchData()'s arguments were renamed this afternoon precisely because that is not what it does. The join is a general spatiotemporal nearest-feature match, and either side may be stations, tag positions, or another gridded product.That made these stale in the way that matters — not incomplete, wrong. A reader deciding whether the package fits their problem would have concluded it did not, on the strength of a sentence describing an earlier version of it.
Title:
Fetch and Match Copernicus Marine Data to Species Observations→Fetch Copernicus Marine Data and Match It in Space and TimeDescription also brought up to date on what has been added since it was last written: daily fetches by period or by named date, parallel downloads, and caching.
GitHub sidebar updated to match, and topics gained
netcdf,time-series,data-pipeline.Going forward
Per Camille's request, refreshing the repo description, README, topics,
DESCRIPTION, andNEWS.mdis now part of pushing rather than a separate chore. The check that matters is whether a change makes any of them untrue rather than merely incomplete — a stale claim is worse than a missing one, which is exactly what happened here.Verification
R CMD check— Status: OK. Full suite green. README re-knitted and all anchors verified. Installed into both R 4.6.1 and 4.3.2.🤖 Generated with Claude Code