Conversation
The README explains but never demonstrates: every example in it is eval = FALSE, because they need Copernicus credentials. The vignette runs. Its covariates are synthetic - a Gulf of Maine grid with a seasonal cycle and winter cloud gaps - so every number and figure in it is computed at build time, while the calls are the ones you would make against a real fetch. That is the part the README cannot do. Coverage dropping to 0.17 in January and back to 0.92 in June is a sentence in the README and a figure here; min_coverage reporting 1 cell rather than 39 is an argument there and an output here. Writing it found a bug. matchData() processes rows a period at a time, so a table whose periods were interleaved came back grouped by period rather than in the order it arrived: 1 2 3 4 in, 1 3 2 4 out. Anyone aligning the result against the input by position - cbind(), or assigning a column straight across - would have got silently mismatched rows. Worse, I had documented the opposite this afternoon, in both the roxygen and the vignette draft, having assumed it rather than checked. The order is now restored before returning, which makes the claim true rather than retracting it, and a test pins it: the covariate has to follow its own row, not merely the row count. Vignette infrastructure added to DESCRIPTION (knitr, rmarkdown, VignetteBuilder), and built HTML is gitignored. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
figure/ is what knitr::knit() writes when run directly on the vignette rather than through R CMD build, which puts its figures inside the package. Three PNGs of synthetic data, regenerated on every build and belonging in neither the repository nor the tarball. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README explains but never demonstrates — every example in it is
eval = FALSE, because they need Copernicus credentials. The vignette runs.Its covariates are synthetic (a Gulf of Maine grid with a seasonal cycle and winter cloud gaps), so every number and figure is computed at build time, while the calls are the ones you would make against a real fetch.
That is the part the README cannot do:
min_coveragereporting 1 cell rather than 39 is an argument there and an output heredownscale_grid(method = "nearest")inventing no values is a claim there andTRUEhereWriting it found a bug
matchData()processes rows a period at a time, so a table whose periods were interleaved came back grouped by period rather than in the order it arrived:Anyone aligning the result against the input by position —
cbind(), or assigning a column straight across — would have got silently mismatched rows.Worse: I had documented the opposite this afternoon, in both the roxygen and the vignette draft, having assumed it rather than checked. The order is now restored before returning, which makes the claim true rather than retracting it.
A test pins it, and checks the covariate follows its own row rather than merely the row count — the failure mode where row counts match but values are shuffled.
Also
DESCRIPTION(knitr,rmarkdown,VignetteBuilder).figure/— knitr scratch output from runningknit()directly rather than throughR CMD build— is gitignored after briefly being committed.Verification
R CMD check— Status: OK, includingchecking re-building of vignette outputs ... OK. Full suite green. Installed into both R 4.6.1 and 4.3.2.Note: pandoc is not on this machine's
PATH; the build used the copy RStudio bundles. CI has its own.🤖 Generated with Claude Code