Skip to content

feat: persist antiban settings per profile#1598

Merged
chsami merged 2 commits intodevelopmentfrom
codex/save-antiban-configuration-in-profile
Nov 9, 2025
Merged

feat: persist antiban settings per profile#1598
chsami merged 2 commits intodevelopmentfrom
codex/save-antiban-configuration-in-profile

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Nov 9, 2025

Summary

  • add JSON-based persistence for antiban settings scoped to the active config profile
  • reload saved antiban settings when the plugin starts or the RuneLite profile changes
  • update antiban UI controls to save changes back to the profile whenever toggles or sliders are adjusted

Testing

  • mvn -pl runelite-client -am -DskipTests compile (fails: repository access to com.google.inject:guice-bom is forbidden in this environment)

Codex Task

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 9, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This PR introduces persistence for antiban settings across the microbot client. Rs2AntibanSettings gains save and load methods using Gson and ConfigManager to store settings in profiles. AntibanPlugin now loads settings on startup and profile changes. Multiple UI panels are updated to immediately save settings when users adjust checkboxes, sliders, and toggles. The changes maintain existing public APIs while adding a serialization layer and updating UI event handlers to trigger profile persistence.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 5.26% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: persist antiban settings per profile' directly and clearly summarizes the main change: adding persistence for antiban settings at the profile level.
Description check ✅ Passed The description is directly related to the changeset, providing summary of the persistence mechanism, reload behavior, and UI updates that match the code changes across multiple files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit 30a791c into development Nov 9, 2025
3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 10, 2025
@chsami chsami deleted the codex/save-antiban-configuration-in-profile branch November 16, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant