2.0.40 by chsami · Pull Request #1601 · chsami/Microbot

chsami · 2025-11-10T22:19:51Z

No description provided.

…-in-profile feat: persist antiban settings per profile

- Adjust getParam0 value for toggle action in menu entry - Update getParam1 value for consistency in menu entry

…el-up-interface Add toggles for microbot blocking events

fix(Rs2Settings): update menu entry parameters for toggle action

coderabbitai · 2025-11-10T22:20:10Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This PR implements per-profile persistence for antiban settings through a new serialization layer in Rs2AntibanSettings with Gson integration. AntibanPlugin loads settings on startup and profile changes, while all antiban UI panels trigger saveToProfile() after user interactions. Two new configuration flags are added to MicrobotConfig (disableLevelUpInterface and disableWorldSwitcherConfirmation, both defaulting to true) and integrated into their respective event classes via config-based gating logic. The microbot.version property is bumped from 2.0.39 to 2.0.40. Minor updates include menu entry parameter adjustments in Rs2Settings, case-insensitive item name matching in Rs2Fletching, and a commented line in Rs2Prayer.

Possibly related PRs

feat: persist antiban settings per profile #1598: Implements identical antiban per-profile persistence architecture with Rs2AntibanSettings save/load and UI panel integration
Add toggles for microbot blocking events #1600: Adds the same MicrobotConfig toggles (disableLevelUpInterface, disableWorldSwitcherConfirmation) and gates event execution on these flags
fix(Rs2Settings): update menu entry parameters for toggle action #1599: Modifies the same numeric parameters in Rs2Settings menu entry constructions (getParam1 to 8781844 and getParam0 to 35)

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author, making it impossible to assess relevance to the changeset.	Add a pull request description that explains the changes, including the antiban settings persistence layer, new config options, and event gating logic.
Docstring Coverage	⚠️ Warning	Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Title check	❓ Inconclusive	The title '2.0.40' matches the version bump in pom.xml but is vague and lacks descriptive context about the actual changes.	Consider a more descriptive title that summarizes the primary changes, such as 'Add antiban settings persistence and config-based event gating' or similar.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/skills/fletching/Rs2Fletching.java (1)
418-421: Optimize: Move toLowerCase() outside the lambda.

Calling itemName.toLowerCase() inside the lambda causes it to be computed for each inventory item. Since itemName doesn't change, compute it once before the lambda.

Apply this diff:
 public static void dropFletchedItems(String itemName) {
-    Rs2Inventory.dropAll(rsitem -> rsitem.getName().toLowerCase().contains(itemName.toLowerCase()), InteractOrder.ZIGZAG);
+    String lowerItemName = itemName.toLowerCase();
+    Rs2Inventory.dropAll(rsitem -> rsitem.getName().toLowerCase().contains(lowerItemName), InteractOrder.ZIGZAG);
     log.info("dropped fletched items: {}", itemName);
 }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf94aee and 1a571e3.

📒 Files selected for processing (16)

runelite-client/pom.xml (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotConfig.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/AntibanPlugin.java (2 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/Rs2AntibanSettings.java (2 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/ActivityPanel.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/CooldownPanel.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/GeneralPanel.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MasterPanel.java (2 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MicroBreakPanel.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MousePanel.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/ProfilePanel.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/DisableLevelUpInterfaceEvent.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/DisableWorldSwitcherConfirmationEvent.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/prayer/Rs2Prayer.java (1 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/settings/Rs2Settings.java (2 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/skills/fletching/Rs2Fletching.java (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/**/*.java

📄 CodeRabbit inference engine (AGENTS.md)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/**/*.java: Place all gameplay automation code under runelite-client/src/main/java/net/runelite/client/plugins/microbot
Prefix configuration interfaces with the plugin name (e.g., ExampleConfig) within microbot plugins

Files:

runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotConfig.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/AntibanPlugin.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/ProfilePanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MousePanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/DisableLevelUpInterfaceEvent.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/CooldownPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/skills/fletching/Rs2Fletching.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/settings/Rs2Settings.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/GeneralPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MasterPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/ActivityPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MicroBreakPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/Rs2AntibanSettings.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/prayer/Rs2Prayer.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/DisableWorldSwitcherConfirmationEvent.java

**/*.java

📄 CodeRabbit inference engine (AGENTS.md)

**/*.java: Use tabs for indentation, follow the brace placement style exemplified in MicrobotPlugin.java, and keep lines under 120 characters
Use UpperCamelCase for types and lowerCamelCase for members

Files:

runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotConfig.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/AntibanPlugin.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/ProfilePanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MousePanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/DisableLevelUpInterfaceEvent.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/CooldownPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/skills/fletching/Rs2Fletching.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/settings/Rs2Settings.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/GeneralPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MasterPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/ActivityPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MicroBreakPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/Rs2AntibanSettings.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/prayer/Rs2Prayer.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/DisableWorldSwitcherConfirmationEvent.java

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/**/*.java

📄 CodeRabbit inference engine (AGENTS.md)

Put shared helpers under .../microbot/util

Files:

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/AntibanPlugin.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/ProfilePanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MousePanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/DisableLevelUpInterfaceEvent.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/CooldownPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/skills/fletching/Rs2Fletching.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/settings/Rs2Settings.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/GeneralPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MasterPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/ActivityPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/ui/MicroBreakPanel.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/antiban/Rs2AntibanSettings.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/prayer/Rs2Prayer.java
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/events/DisableWorldSwitcherConfirmationEvent.java

**/pom.xml

📄 CodeRabbit inference engine (AGENTS.md)

Target Java 11 via maven-compiler-plugin using 11 in all module POMs

Files:

runelite-client/pom.xml

🧠 Learnings (12)

📓 Common learnings

Learnt from: CR
Repo: chsami/Microbot PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-10-16T17:14:29.778Z
Learning: Applies to runelite-client/src/main/java/net/runelite/client/plugins/microbot/MicrobotPlugin.java : When adding panel controls or overlays, update the Microbot navigation panel setup in MicrobotPlugin and provide default config values

Learnt from: CR
Repo: chsami/Microbot PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-10-16T17:14:29.778Z
Learning: Applies to runelite-client/src/main/java/net/runelite/client/plugins/microbot/**/*.java : Prefix configuration interfaces with the plugin name (e.g., ExampleConfig) within microbot plugins