fix(grandexchange): bound quantity entry retries - #1852
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe Merge Risk: ⚪ Minimal · up to Grand Exchange quantity entry now stops after three unsuccessful attempts rather than stalling indefinitely, while successful updates still complete when the requested quantity is observed. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
no |
Problem
Grand Exchange offer processing could stall indefinitely when the custom quantity button was temporarily unavailable because that retry path bypassed the existing attempt limit.
Solution
Limit quantity entry to three attempts, stop immediately once the requested quantity is observed, and return failure cleanly when the attempts are exhausted.
Additional notes