Skip to content

Revert "fix project settings"#2

Merged
slackmoehrle merged 1 commit into
masterfrom
revert-1-master
Oct 11, 2014
Merged

Revert "fix project settings"#2
slackmoehrle merged 1 commit into
masterfrom
revert-1-master

Conversation

@slackmoehrle

Copy link
Copy Markdown
Contributor

Reverts #1

slackmoehrle added a commit that referenced this pull request Oct 11, 2014
Revert "fix project settings"
@slackmoehrle slackmoehrle merged commit 528c4db into master Oct 11, 2014
@zilongshanren zilongshanren deleted the revert-1-master branch October 11, 2014 03:53
@zilongshanren

Copy link
Copy Markdown
Contributor

@slackmoehrle
Hi, Why revert my commit? Does it do something wrong?

@zilongshanren

Copy link
Copy Markdown
Contributor

@slackmoehrle
the project.xcworkspace folder should be added into the .gitignore file, otherwise it is annoying when every time I change my Xcode project.

And the target related Info.plist file should also be properly named with a unify bundle id, otherwise we will suffer from installing multiple target on the same device.

What your opinion?

@slackmoehrle

Copy link
Copy Markdown
Contributor Author

Because this is my responsibility for the chapters you changed. I already have these changes locally.

Please just worry about your chapters.

Sent from my iPhone

On Oct 10, 2014, at 8:54 PM, 子龙山人 notifications@github.com wrote:

@slackmoehrle
Hi, Why revert my commit? Does it do something wrong?


Reply to this email directly or view it on GitHub.

@slackmoehrle

Copy link
Copy Markdown
Contributor Author

Again. I have done this and you are changing chapters that aren't yours.

Feel free to add xcworkspace to gitignore thanks for catching this.

Send a PR and I will merge it over the weekend.

Sent from my iPhone

On Oct 10, 2014, at 8:57 PM, 子龙山人 notifications@github.com wrote:

@slackmoehrle
the project.xcworkspace folder should be added into the .gitignore file, otherwise it is annoying when every time I change my Xcode project.

And the target related Info.plist file should also be property named with correct bundle id, otherwise we will suffer from installing multiple target on the same device.

What your opinion?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants