Skip to content

introduce Sub-Project Committer in Contributor Ladder#320

Merged
xmulligan merged 2 commits intomainfrom
pr/mtardy/update-cilium-contributor-ladder
Nov 24, 2025
Merged

introduce Sub-Project Committer in Contributor Ladder#320
xmulligan merged 2 commits intomainfrom
pr/mtardy/update-cilium-contributor-ladder

Conversation

@mtardy
Copy link
Copy Markdown
Member

@mtardy mtardy commented Oct 30, 2025

This new role is introduced because sub-project like Tetragon need an intermediate role between Reviewer and Committer to operate correctly and can't from the status quo.

Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
@xmulligan
Copy link
Copy Markdown
Member

I think overall this is headed in the right direction. We might want to update Core Scope Repositories to something like sub-projects.

We don't need to merge this but my editor was always auto triming the
whitespace.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy mtardy force-pushed the pr/mtardy/update-cilium-contributor-ladder branch from 107c4db to aaea23b Compare October 31, 2025 16:12
@mtardy mtardy marked this pull request as ready for review October 31, 2025 16:13
@mtardy mtardy requested a review from a team as a code owner October 31, 2025 16:13
Copy link
Copy Markdown
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you become a Committer when you are already a Sub-Project Committer?

Copy link
Copy Markdown
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a step in the right direction given the various different components that fall under the Cilium organization banner.

Comment thread CONTRIBUTOR-LADDER.md Outdated
@mtardy mtardy changed the title introduce Core Scope Repository Committer in Contributor Ladder introduce Sub-Project Committer in Contributor Ladder Nov 3, 2025
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
Comment thread CONTRIBUTOR-LADDER.md Outdated
@mtardy mtardy force-pushed the pr/mtardy/update-cilium-contributor-ladder branch from e53bb9f to 543e759 Compare November 3, 2025 15:20
@mtardy
Copy link
Copy Markdown
Member Author

mtardy commented Nov 3, 2025

How do you become a Committer when you are already a Sub-Project Committer?

That's actually an interesting question, are we going toward mostly sub-project committers in the future, and what would justify wanting/or granting someone general organizer committer? Maybe that could mean some people could choose to become sub-project committers instead of committers if they want to focus on a specific project as well.

Comment thread CONTRIBUTOR-LADDER.md
Comment thread CONTRIBUTOR-LADDER.md Outdated
@xmulligan
Copy link
Copy Markdown
Member

How do you become a Committer when you are already a Sub-Project Committer?

I would leave the process as is right now (the current Committers vote to add new members) until we finish this discussion. There are a couple of different directions this could go, but I think trying to figure that out at the same time as this would slow things down without a real benefit yet.

For voting, I was imagining sub-projects just vote on sub-project matters as michi said. Maybe we should make that more explicit since it is already confusing 😅

@mtardy
Copy link
Copy Markdown
Member Author

mtardy commented Nov 4, 2025

So from the questions above about becoming a Committer when a Sub-Project Committer and votes, it seems from the discussions those two roles can somehow be orthogonal.

You could become a Committer from being a Reviewer given the current rules. You don't need to go from Sub-Project Committer to Reviewer and the same rule would apply for you to jump from Sub-Project Committer to Committer. As Joe highlighted in a conversation, being a Sub-Project Committer is certainly a plus in an application but not a requirement.

For the vote it seems the agreement from the discussion and Joe and Michi's comments that:

  1. Only Sub-Project Committers vote for electing new Sub-Project Committers.
  2. Sub-Project Committers might also vote for matters concerning the Sub-Project.
  3. Sub-Project Committers might vote for org wide decision that would affect the Sub-Project (but this one TBD, we can discuss this).

I'll try to reflect that on the document, and let's merge if we can. I don't think we can resolve all those questions now but these will present themselves later on.

@mtardy mtardy force-pushed the pr/mtardy/update-cilium-contributor-ladder branch from 543e759 to 6057fe0 Compare November 4, 2025 11:38
This new role is introduced because sub-project like Tetragon need an
intermediate role between Reviewer and Committer to operate correctly
and can't from the status quo.

Co-authored-by: Bill Mulligan <billmulligan516@gmail.com>
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy mtardy force-pushed the pr/mtardy/update-cilium-contributor-ladder branch from 6057fe0 to 466b010 Compare November 4, 2025 11:42
@mtardy
Copy link
Copy Markdown
Member Author

mtardy commented Nov 4, 2025

I'll try to reflect that on the document, and let's merge if we can. I don't think we can resolve all those questions now but these will present themselves later on.

Those are the changes applied from this discussion.

I'd love to merge this PR now if everyone is satisfied. I can't click the button myself (I guess I need to be a Committer for that 😉).

EDIT: other changes can be made without this to be blocking, we can wait a little bit for people to comment on this

@xmulligan xmulligan requested a review from lizrice November 5, 2025 08:23
@bowei
Copy link
Copy Markdown
Member

bowei commented Nov 24, 2025

/lgtm

@xmulligan xmulligan merged commit a475182 into main Nov 24, 2025
1 check passed
@xmulligan xmulligan deleted the pr/mtardy/update-cilium-contributor-ladder branch November 24, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants