introduce Sub-Project Committer in Contributor Ladder#320
Conversation
|
I think overall this is headed in the right direction. We might want to update Core Scope Repositories to something like sub-projects. |
We don't need to merge this but my editor was always auto triming the whitespace. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
107c4db to
aaea23b
Compare
pchaigno
left a comment
There was a problem hiding this comment.
How do you become a Committer when you are already a Sub-Project Committer?
joestringer
left a comment
There was a problem hiding this comment.
I think this is a step in the right direction given the various different components that fall under the Cilium organization banner.
e53bb9f to
543e759
Compare
That's actually an interesting question, are we going toward mostly sub-project committers in the future, and what would justify wanting/or granting someone general organizer committer? Maybe that could mean some people could choose to become sub-project committers instead of committers if they want to focus on a specific project as well. |
I would leave the process as is right now (the current Committers vote to add new members) until we finish this discussion. There are a couple of different directions this could go, but I think trying to figure that out at the same time as this would slow things down without a real benefit yet. For voting, I was imagining sub-projects just vote on sub-project matters as michi said. Maybe we should make that more explicit since it is already confusing 😅 |
|
So from the questions above about becoming a Committer when a Sub-Project Committer and votes, it seems from the discussions those two roles can somehow be orthogonal. You could become a Committer from being a Reviewer given the current rules. You don't need to go from Sub-Project Committer to Reviewer and the same rule would apply for you to jump from Sub-Project Committer to Committer. As Joe highlighted in a conversation, being a Sub-Project Committer is certainly a plus in an application but not a requirement. For the vote it seems the agreement from the discussion and Joe and Michi's comments that:
I'll try to reflect that on the document, and let's merge if we can. I don't think we can resolve all those questions now but these will present themselves later on. |
543e759 to
6057fe0
Compare
This new role is introduced because sub-project like Tetragon need an intermediate role between Reviewer and Committer to operate correctly and can't from the status quo. Co-authored-by: Bill Mulligan <billmulligan516@gmail.com> Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
6057fe0 to
466b010
Compare
Those are the changes applied from this discussion.
EDIT: other changes can be made without this to be blocking, we can wait a little bit for people to comment on this |
|
/lgtm |
This new role is introduced because sub-project like Tetragon need an intermediate role between Reviewer and Committer to operate correctly and can't from the status quo.