fix: honor output-tunnel in JSON output#690
Merged
Merged
Conversation
immanuwell
force-pushed
the
fix/json-output-tunnel-flag
branch
from
f938b57 to
e96e564
Compare
Signed-off-by: immanuwell <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix/json-output-tunnel-flag
branch
from
e96e564 to
5e3a7af
Compare
smagnani96
approved these changes
Jul 6, 2026
smagnani96
left a comment
smagnani96
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the catch 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrintJson()checkedOutputTuplefortunnel_tuple, notOutputTunnel.So 2 cases get kinda weird:
pwru --output-json --output-tunnel --output-tuple=falsedropstunnel_tuplepwru --output-json --output-tuple --output-tunnel=falsestill printstunnel_tupleThis switches the guard to
OutputTunneland adds regression tests. Pretty small fix, but it keeps JSON output lined up with the flags.Repro:
go test ./internal/pwru -run "TestPrintJSON|TestGetAbsoluteTs" -vTestPrintJSON...cases fail