fix: honor output-tcp-flags in JSON output#691
Merged
Conversation
rgo3
requested changes
Jul 9, 2026
rgo3
left a comment
rgo3
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. Two suggestions inline.
immanuwell
force-pushed
the
fix-output-json-tcp-flags
branch
from
99a2925 to
33c1ce4
Compare
Contributor
Author
|
@rgo3 addressed all suggestions, PTAL |
rgo3
reviewed
Jul 10, 2026
immanuwell
force-pushed
the
fix-output-json-tcp-flags
branch
from
33c1ce4 to
86b2d1b
Compare
Contributor
Author
|
@rgo3 please take a look |
Signed-off-by: immanuwell <pchpr.00@list.ru>
rgo3
force-pushed
the
fix-output-json-tcp-flags
branch
from
86b2d1b to
5211d51
Compare
rgo3
approved these changes
Jul 13, 2026
rgo3
left a comment
rgo3
left a comment
Contributor
There was a problem hiding this comment.
Simplified it a bit, guess I kinda led you a stray with that many test options. Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--output-tcp-flagsworks in text output, but JSON was doing its own thing and always emittedtuple.flags.Repro
go test ./internal/pwru -run TestPrintJSONHonorsOutputTCPFlags -count=1Before this patch it fails,
tuple.flagsis still there when the flag is off.Fix
Only set
tuple.flagsfor JSON when--output-tcp-flagsis enabled.Added tests for both off and on cases.