Added the option to show network namespace names where possible#692
Merged
Conversation
Signed-off-by: Owen Smith <owensmith0031@gmail.com>
91968ba to
0954e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Firstly, thanks for this great project, it's come in very handy!
This PR adds the option to show network namespace names (where possible). This is disabled by default. Two new flags have been added:
--output-netns-names=(true|false)- This enables including the information in the table or JSON output.--netns-names-max-length- This sets the maximum amount of chars from each name to display. Only relevant when using the table output.Example Outputs
Default + output-netns-names (
pwru --output-netns-names=true)No Meta (
pwru --output-netns-names=true --output-meta=false)I'm conscious there isn't an open issue for this, apologies. I completely understand if this isn't wanted functionality.