Fix ZWNJ literal in fa_ir NOT_ALPHA message (staticcheck ST1018) - #235
Merged
Conversation
staticcheck ST1018 flags a raw U+200C (zero-width non-joiner) character in a string literal; use the backslash-u-200c escape sequence instead, same as every other ZWNJ already in this file. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FLdVmP5daHiknrTW4Geh2i
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 60 +2
Lines 1087 1106 +19
=========================================
+ Hits 1087 1106 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainis currently red: thebuildCI job fails onstaticcheck:Introduced in #231 (
alpha/numericcheckers) — the fa-IR translation forNOT_ALPHAhad a raw zero-width non-joiner character embedded directly in the string literal instead of the escaped form every other ZWNJ in this file already uses (see #178, which fixed this exact class of issue previously).Fix
Replace the raw U+200C with the
\u200cescape sequence, matching the existing convention in the same file.Verification
Local
staticcheckcan't run in this environment (Go toolchain version mismatch unrelated to this change), so verified with a Unicode-category scan across every.gofile in the repo for anyCf(format) character — confirms this was the only occurrence.go build,go vet,go test -race(100% coverage),gosec,reviveall clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01FLdVmP5daHiknrTW4Geh2i