Docs: Add link to request x86_64 Docker image#215
Merged
Conversation
Signed-off-by: Kate Andrews <keandrews@gmail.com>
auxesis
requested changes
Apr 30, 2025
Contributor
auxesis
left a comment
auxesis
left a comment
There was a problem hiding this comment.
This is a good start, and we should move it to a reference doc.
| > **Prerequisites:** Before you start you need to have this software installed: | ||
| > - [Docker](https://www.docker.com/) — see Docker's [documentation for installing](https://docs.docker.com/get-started/get-docker/) | ||
| > | ||
| > **Supported architectures:** We currently support `arm64v8` architectures. If you're interested in a `x86_64` Docker image, upvote [this idea](https://github.com/cipherstash/proxy/discussions/214). |
Contributor
There was a problem hiding this comment.
Suggested change
| > **Supported architectures:** We currently support `arm64v8` architectures. If you're interested in a `x86_64` Docker image, upvote [this idea](https://github.com/cipherstash/proxy/discussions/214). | |
| > **Supported architectures:** CipherStash Proxy provides Docker images for these architectures: `linux/arm64` | |
| > If you're interested in a Docker image for other architectures (like `linux/amd64`), upvote [this idea](https://github.com/cipherstash/proxy/discussions/214). |
Contributor
There was a problem hiding this comment.
Also, I think this might be better in a reference doc, rather than in the main README.
It's too low a level of detail for a getting started guide, but it's the sort of thing that makes sense in a reference doc.
Signed-off-by: Kate Andrews <keandrews@gmail.com>
Signed-off-by: Kate Andrews <keandrews@gmail.com>
auxesis
approved these changes
May 1, 2025
Contributor
auxesis
left a comment
auxesis
left a comment
There was a problem hiding this comment.
Thanks @kateandrews!
I have added one small suggested copy change.
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com> Signed-off-by: Kate Andrews <keandrews@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acknowledgment
By submitting this pull request, I confirm that CipherStash can use, modify, copy, and redistribute this contribution, under the terms of CipherStash's choice.