feat: check column configuration against encrypted column before decrypt#231
Merged
tobyhede merged 1 commit intoMay 16, 2025
Conversation
tobyhede
force-pushed
the
check-column-configuration-on-decrypt
branch
4 times, most recently
from
2d9cb7c to
035981d
Compare
coderdan
approved these changes
May 16, 2025
Contributor
coderdan
left a comment
coderdan
left a comment
There was a problem hiding this comment.
Nice. Looks good to me.
The other part of the confused deputy problem is to include the identifier in the lock context (or in the aad of the local ciphertext at least). Not sure if that's been done/carded up but would be a necessary element.
tobyhede
force-pushed
the
check-column-configuration-on-decrypt
branch
from
035981d to
81cff57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the identifier in the returned ciphertext matches the identifier in the column configuration before decryption.
Returns an error if a mismatch is detected.
Helps protect against confused deputy attacks.