Skip to content

fix(deps): patch brace-expansion to >= 5.0.5 (CVE-2026-33750)#333

Merged
tobyhede merged 1 commit intomainfrom
fix/cip-2938-brace-expansion-patch
Mar 30, 2026
Merged

fix(deps): patch brace-expansion to >= 5.0.5 (CVE-2026-33750)#333
tobyhede merged 1 commit intomainfrom
fix/cip-2938-brace-expansion-patch

Conversation

@tobyhede
Copy link
Copy Markdown
Contributor

@tobyhede tobyhede commented Mar 30, 2026

Summary

  • CIP-2938 (Medium): brace-expansion 5.0.3 → >=5.0.5 — CVE-2026-33750 infinite loop DoS

Changes

  • Added pnpm override for brace-expansion@^5 (>=5.0.5)
  • Regenerated pnpm-lock.yaml

Test plan

  • pnpm why brace-expansion shows 5.0.5, no 5.0.3
  • CI passes

Refs: CIP-2938

Summary by CodeRabbit

  • Chores
    • Updated dependency resolution to ensure package compatibility.

Infinite loop DoS via zero step value in brace patterns.

Refs: CIP-2938
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2026

⚠️ No Changeset found

Latest commit: c309805

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f1bf9150-65a6-48b5-8b0c-7582b917d02f

📥 Commits

Reviewing files that changed from the base of the PR and between 4aac020 and c309805.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

A pnpm dependency override was added to package.json for the brace-expansion package, specifying version constraints >=5.0.5 to ensure consistent resolution across the project's dependency tree.

Changes

Cohort / File(s) Summary
Dependency Override
package.json
Added pnpm override entry for brace-expansion@^5 to enforce minimum version >=5.0.5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • freshtonic
  • coderdan

Poem

🐰 A little override hopped into place,
Where brace-expansion found its space,
Version five, now locked so tight,
Dependencies resolved just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a pnpm override to patch brace-expansion to version >=5.0.5 to address CVE-2026-33750, which directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cip-2938-brace-expansion-patch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tobyhede tobyhede merged commit abf3ddd into main Mar 30, 2026
6 checks passed
@tobyhede tobyhede deleted the fix/cip-2938-brace-expansion-patch branch March 30, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants