fix: reject late writes from covering ROMs - #248
Draft
NullWitnessZK wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #244.
Minimal reproducer
Save as
main.zok:Use
i = 1andv = 99.Expected
The store guard is the literal
false, so the store is dead anda[1]must equal11. A public claimreturn = 99must be rejected.Actual
The finalized relation accepts both:
Debug output identifies a covering ROM with a lookup haystack of five entries: four real initialization writes plus the one dead conditional write.
Why it happens
Ram::is_covering_romadmits a late write when its active flag is false, but the covering-ROM checker does not encode that active flag. It places the dead write's private(i, v)pair into the lookup haystack, allowing it to justify an arbitrary read value.Impact: transcript-array underconstraint/soundness.
Proposed fix
fix/covering-rom-dead-storeata1a5504rejects every late access whose write flag is not statically false, regardless of its active flag.Self-contained regression:
cargo test covering_rom_rejects_inactive_late_write