Limit sinks to Measurement[A] values#281
Merged
gpampara merged 5 commits intociren:masterfrom Apr 23, 2018
Merged
Conversation
Adjusted the missing implicit message to be more clear and to include the new instance, for the benefit of the user.
stefanvds
approved these changes
Apr 23, 2018
stefanvds
left a comment
stefanvds
left a comment
There was a problem hiding this comment.
Change looks good. Branch compiles and runs on my machine, and the code review seems more logical with the requirement for Measurement.
filinep
approved these changes
Apr 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was found by @stefanvds with the use of a sink in the runner process pipeline. When setting up a pipeline (without using a
measurefunction), compilation would cause the compiler to try create a derivation that never completed. I'm actually surprised that the compiler didn't crash, although I suspect letting the compiler continue, without intervention, would eventually result in a crash. The specific case highlighted by @stefanvds had the compiler running for over 20 minutes.Limiting all sinks to instead only accept
Measurement[A]values corrects the derivation problem. In retrospect, it makes sense to only allowMeasurement[A]values to be serialized through the sinks.Naturally, this does not prevent alternate usage, but to use the sinks defined in the
iomodule, a measurement needs to be done to allow the compilation to succeed now, not doing so results in a compiler error (as it should be).